Meeting with the openSUSE Review Team @ oSC17

Some notes from the meeting with the openSUSE review team at the openSUSE Conference 2017:

• One workflow was to parse the OBS mail notifications to fetch the request numbers and finally creating links to OBS
• RPM lint result repository and architecture should be prefilled with the target project of the request (this is a special case for openSUSE as the target project matches with the repository)
• To get the priority of the reviews the attendees use different approaches. They don't use the review / request priority attribute (e.g. looking at Factory Dashboard, FCFS...)
• The diff should be limited
  • for better scrolling (https://github.com/openSUSE/open-build-service/issues/3186) - fixed
  • faster page loading, often results in time out for big projects (e.g. kernel). Idead: skip the diff or e.g. load it only if required (like GitHub does it for big files) or link to the upstream code if it is identical
• The review should indicate if it is a new package (review is more complex and takes longer) or e.g. just a version bump done in https://github.com/openSUSE/open-build-service/pull/3960
• OSC misses the rpmlint result completely
• For superseded reviews it should be possible to show the diff between the reviews (fixed in https://github.com/openSUSE/open-build-service/pull/5162)
• For superseded reviews it should show the comments of the superseded review too (fixed in https://github.com/openSUSE/open-build-service/pull/3919)
• It would be nice to show the diff between rpmlint results (to see if it is a new rpmlint issue or it already got accepted before). Could be implemented by the review team itself and OBS just displays the diff file.
• Dedicated review page with next/previous review button / shortcut
• Switching roles / groups on the user page (https://trello.com/c/H0fZCfFi/319-5-allow-filtering-of-requests-reviews-and-bug-issues-by-user-groups) (fixed in https://github.com/openSUSE/open-build-service/pull/3782)
• There is a large gap between comments and state of the review. This should be together. https://github.com/openSUSE/open-build-service/issues/3184 - fixed
• It should be possible to link reviews in comments (link to superseded / history) (fixed in https://github.com/openSUSE/open-build-service/pull/7498)