Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refactorization lost in some merge #111

Merged
merged 1 commit into from
Mar 10, 2014
Merged

Fix refactorization lost in some merge #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions osclib/request_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _filter_review_by_project(self, element, state):
if r.get('by_project') and r.get('state') == state]
return reviews

def _new_review_by_project(self, request_id, element):
def _is_new_review_by_project(self, request_id, element):
"""
Takes a XML that contains a list of reviews and return True if
'request' is in the list with state as 'new'.
Expand Down Expand Up @@ -79,7 +79,7 @@ def find_request_id(self, request_id):
raise oscerr.WrongArgs(msg)
self.srs[int(request_id)] = {'project': project}

review = self._new_review_by_project(request_id, root)
review = self._is_new_review_by_project(request_id, root)
if review:
self.srs[int(request_id)]['staging'] = review

Expand Down Expand Up @@ -110,7 +110,7 @@ def find_request_package(self, package):

self.srs[request] = {'project': 'openSUSE:Factory', 'state': state}

review = self._new_review_by_project(request, sr)
review = self._is_new_review_by_project(request, sr)
if review:
self.srs[int(request)]['staging'] = review

Expand Down