Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devel-project: notify: catch smtp exceptions rather than crashing. #1894

Merged

Conversation

jberry-suse
Copy link
Contributor

As requested in poo#39467. Other uses of mail_send() use mailing lists as to address and should explode if they fail.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4670

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 27.701%

Changes Missing Coverage Covered Lines Changed/Added Lines %
devel-project.py 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
devel-project.py 1 51.52%
Totals Coverage Status
Change from base Build 4668: -0.01%
Covered Lines: 4290
Relevant Lines: 15487

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4670

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 27.701%

Changes Missing Coverage Covered Lines Changed/Added Lines %
devel-project.py 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
devel-project.py 1 51.52%
Totals Coverage Status
Change from base Build 4668: -0.01%
Covered Lines: 4290
Relevant Lines: 15487

💛 - Coveralls

@coolo coolo merged commit bb2cb5c into openSUSE:master Mar 9, 2019
@jberry-suse jberry-suse deleted the devel-project-notify-smtp-exception-catch branch March 20, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants