pkglistgen: ignore bootstrap_copy repo #2539
Conversation
Pull Request Test Coverage Report for Build 6412
💛 - Coveralls |
|
Add that default to osclib/conf.py instead so it's discoverable |
Never use the bootstrap_copy repo for package solving. Staging content might be very different so don't confuse the solver.
|
https://botmaster.suse.de/go/tab/build/detail/Pkglistgen.openSUSE_Factory/11219/pkglistgen/1/openSUSE_Factory_ARM - your default is not working |
| @@ -578,7 +578,8 @@ def update_and_solve_target(self, api, target_project, target_config, main_repo, | |||
| project, scope, force, no_checkout, | |||
| only_release_packages, stop_after_solve): | |||
| self.all_architectures = target_config.get('pkglistgen-archs').split(' ') | |||
| self.repos = self.expand_repos(project, main_repo) | |||
| ignore_repos = set(target_config.get('pkglistgen-ignore_repos').split(' ')) | |||
| self.repos = [ r for r in self.expand_repos(project, main_repo) if r[0] != project or r[1] not in ignore_repos ] | |||
There was a problem hiding this comment.
Is it intentional that the ignore_repos list doesn't influence recursive expansion?
If you have e.g. projectA/standard -> projectB/bootstrap_copy -> projectC/standard, then it would solve against projectA/standard -> projectC/standard
There was a problem hiding this comment.
project C doesn't contain any packages in the factory case so doesn't matter.
This PR actually defines defaults for So either this needs to define defaults for the other projects as well or it's necessary to configure it explicitly everywhere. I'm in favor of the former, because most projects don't need this setting. |
|
obviously the method is discoverable |
|
This also seems to have broken all ring1 stagings in Factory, which can no longer find libc.so.6 and anything else from |
Never use the bootstrap_copy repo for package solving. Staging content
might be very different so don't confuse the solver.