Check for maintainers in the source project #2601
Conversation
imobachgs
force-pushed
the
maintainers-check
branch
2 times, most recently
from
3f97af6
to
2757b3b
Compare
imobachgs
force-pushed
the
maintainers-check
branch
from
2757b3b
to
13801e2
Compare
* It introduces a new configuration parameter 'required-source-maintainer'. * If defined, it is expected to be a maintainer of the devel project. * If that's not the case, the request is declined and an add_role request is created. Co-authored-by: Ancor Gonzalez Sosa <ancor@suse.de> Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.com>
imobachgs
force-pushed
the
maintainers-check
branch
from
13801e2
to
1e868aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
+ Coverage 25.01% 25.13% +0.11%
==========================================
Files 91 91
Lines 15113 15141 +28
==========================================
+ Hits 3781 3806 +25
- Misses 11332 11335 +3
Continue to review full report at Codecov.
|
|
now it looks good for me, but I am not domain expert |
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.com>
| @@ -11,6 +11,8 @@ | |||
| except ImportError: | |||
| import cElementTree as ET | |||
|
|
|||
| from lxml import etree as ETL | |||
There was a problem hiding this comment.
do we really need two XML libraries in here now? we have xml.etree(or cElementTree) and lxml both imported (works, of course, but…)
There was a problem hiding this comment.
actually cElementTree is supposed to die, but we can do that refactoring later IMO
There was a problem hiding this comment.
sure - no problem in going with what we have now
required-source-maintainer.add_rolerequest is created.Fixes #2429