Fix sle15 literal import #2990
Merged
Fix sle15 literal import #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcermak
force-pushed
the
fix-sle15-literal-import
branch
from
aef9bca
to
ca606b7
Compare
Vogtinator
reviewed
Jul 14, 2023
dcermak
force-pushed
the
fix-sle15-literal-import
branch
2 times, most recently
from
ba72f62
to
0340bac
Compare
Vogtinator
reviewed
Jul 14, 2023
Vogtinator
reviewed
Jul 14, 2023
Vogtinator
reviewed
Jul 14, 2023
.github/workflows/ci-test.yml
Outdated
|
|
||
| - name: FIXME, install missing dependencies | ||
| run: | | ||
| zypper -n in python3-requests python3-typing_extensions |
There was a problem hiding this comment.
requests is missing on both os versions
Vogtinator
reviewed
Jul 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
+ Coverage 28.45% 28.48% +0.02%
==========================================
Files 85 85
Lines 14698 14714 +16
==========================================
+ Hits 4183 4191 +8
- Misses 10515 10523 +8
☔ View full report in Codecov by Sentry. |
Vogtinator
reviewed
Jul 14, 2023
dcermak
force-pushed
the
fix-sle15-literal-import
branch
from
20e5fd4
to
3b66b57
Compare
Co-authored-by: Fabian Vogt <fabian@ritter-vogt.de>
dcermak
force-pushed
the
fix-sle15-literal-import
branch
from
3b66b57
to
838b3e5
Compare
|
The test failure is a failure uploading to codecov. |
Vogtinator
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.