Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ZSTD compressed primary.xml.zst #3033

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

Vogtinator
Copy link
Member

@Vogtinator Vogtinator commented Nov 22, 2023

Should work but I only got around to test repo2fileprovides.py yet.

Fixes #3032

@@ -1,6 +1,5 @@

import glob
import gzip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's other users of gzip module in this fule. See ci failure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it differently, gzip and io are now gone

@Vogtinator
Copy link
Member Author

For installcheck to work on TW DoD again we'll need openSUSE/libsolv#544

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3a138b5) 28.46% compared to head (dc4c6bb) 28.47%.
Report is 9 commits behind head on master.

Files Patch % Lines
repo2fileprovides.py 0.00% 6 Missing ⚠️
pkglistgen/update_repo_handler.py 0.00% 4 Missing ⚠️
osclib/repochecks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   28.46%   28.47%           
=======================================
  Files          85       85           
  Lines       14722    14719    -3     
=======================================
  Hits         4191     4191           
+ Misses      10531    10528    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add explicit zstd support to repo2fileprovides.py and port
update_repo_handler.py over to use libsolv's transparent decompression.
@Vogtinator Vogtinator merged commit 24f3d6b into openSUSE:master Nov 23, 2023
11 checks passed
@Vogtinator Vogtinator deleted the zst branch November 23, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkglistgen: update_repo_handler does not cope with new zstd compressed metadata (primary)
3 participants