Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding BMC via CLI #209

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Fix adding BMC via CLI #209

merged 3 commits into from
Mar 25, 2024

Conversation

SchoolGuy
Copy link
Collaborator

@SchoolGuy SchoolGuy commented Jun 23, 2023 •
edited

Fixes #176

Fixes adding the BMC via the CLI.

TODO:

@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 2 times, most recently from c113b10 to f7ed566 Compare July 13, 2023 14:58
@SchoolGuy
Copy link
Collaborator Author

While starting to test if my changes are working I discovered that much of the data is missing that is required to do so. As such #217 must be fixed before this PR can be worked on.

@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 3 times, most recently from 77fe6de to 278d193 Compare July 28, 2023 07:23
@SchoolGuy
Copy link
Collaborator Author

So atm the problem is that when using the production database one cannot load it. I am investigating why this is the case.

@SchoolGuy
Copy link
Collaborator Author

Production database loaded successfully now into my test setup. I will continue testing this PR now manually.

@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 2 times, most recently from 951a8d7 to 0974631 Compare August 24, 2023 07:47
@SchoolGuy
Copy link
Collaborator Author

Creating the tests is more complex than I thought because somebody thought implementing non-standard authentication was a great idea. As such one more side quest is required to make this work...

@SchoolGuy
Copy link
Collaborator Author

One last test is failing. After that I need to split/clean up the PR.

@SchoolGuy
Copy link
Collaborator Author

The last failing test is not easy to fix as there are no tests for the CLI that verify that it doesn't break. As such I will need to create them too. This will happen in the context of this PR.

@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 2 times, most recently from 9742bcf to cfcc70c Compare October 6, 2023 08:38
@SchoolGuy SchoolGuy mentioned this pull request Oct 12, 2023
Merged
@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 2 times, most recently from 0cce94a to 3236190 Compare October 13, 2023 06:29
@SchoolGuy SchoolGuy mentioned this pull request Oct 13, 2023
Closed
@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 5 times, most recently from 4021ed9 to d4eba3e Compare January 26, 2024 15:40
@SchoolGuy SchoolGuy mentioned this pull request Mar 22, 2024
Merged
@SchoolGuy SchoolGuy force-pushed the fix/cli-bmc-add branch 2 times, most recently from 2b1ee4b to bcee6d4 Compare March 25, 2024 08:58
@SchoolGuy SchoolGuy marked this pull request as ready for review March 25, 2024 09:00
@SchoolGuy
Copy link
Collaborator Author

The two tests that are related to the BMC are now passing. As such I believe this PR is improving the code quality.

watologo1
watologo1 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@watologo1 watologo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test the BMCAPIForm additions, but the changes look correct and make sense.

@SchoolGuy SchoolGuy merged commit 8b8fb26 into master Mar 25, 2024
10 of 11 checks passed
@SchoolGuy SchoolGuy deleted the fix/cli-bmc-add branch March 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watologo1 watologo1 watologo1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add bmc fails
2 participants
@SchoolGuy @watologo1