actions: Correctly check previews reviewer #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
reviewed
Sep 30, 2022
| reviewers = [ | ||
| review.reviewer | ||
| for review in (request.review_list() for request in declined_requests) | ||
| for review in rejects.review_list() |
There was a problem hiding this comment.
Maybe it should look like this? Haven't tested it
rejects = [
 request.review_list()
 for request in declined_requests
 ][0]
...
reviewers = [
 review.reviewer
for review in rejects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix feels wrong. It makes two tests pass that were marked as broken. Either there's a bug that nobody noticed because the check would never have worked. Or there's something in the test that I don't understand.
See: https://progress.opensuse.org/issues/104781