add meaningful error if no attribute name

openSUSE · Dec 8, 2017 · 43be8f0 · 43be8f0
1 parent b1d6d83
commit 43be8f0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/osc/core.py b/osc/core.py
@@ -288,6 +288,8 @@ def error(msg, xml):
 
         for service in services:
             name = service.get('name')
+            if name is None:
+                error("invalid service definition. Attribute name missing.", service)
             if len(name) < 3 or '/' in name:
                 error("invalid service name: %s" % name, service)
             mode = service.get('mode', '')