Skip to content

Commit

Permalink
update default list of request states
Browse files Browse the repository at this point in the history
Hi,

"declined" was some time ago changed to be considered an "open" request state.

the default behavior of "osc rq list" is IMHO to show open requests (requests
in state new or review), so I'm attaching a patch that adds "declined" as
well.

Tia,
Dirk

From 73fd10a2203be8e9dc215106648b2d9686d8fdc5 Mon Sep 17 00:00:00 2001
From: Dirk Mueller <dmueller@suse.com>
Date: Mon, 10 Sep 2012 10:40:48 +0200
Subject: [PATCH] add 'declined' to list of default states for rq list

osc rq list should show all currently "open" requests. "declined"
is an open request state, so it should be included by default.
  • Loading branch information
dirkmueller authored and adrianschroeter committed Sep 10, 2012
1 parent ab28b8f commit 4b44e74
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions osc/commandline.py
Expand Up @@ -1747,7 +1747,7 @@ def do_changedevelrequest(self, subcmd, opts, *args):
help='all states. Same as\'-s all\'')
@cmdln.option('-f', '--force', action='store_true',
help='enforce state change, can be used to ignore open reviews')
@cmdln.option('-s', '--state', default='', # default is 'all' if no args given, 'new,review' otherwise
@cmdln.option('-s', '--state', default='', # default is 'all' if no args given, 'declined,new,review' otherwise
help='only list requests in one of the comma separated given states (new/review/accepted/revoked/declined) or "all" [default="new,review", or "all", if no args given]')
@cmdln.option('-D', '--days', metavar='DAYS',
help='only list requests in state "new" or changed in the last DAYS. [default=%(request_list_days)s]')
Expand Down Expand Up @@ -1871,7 +1871,7 @@ def do_request(self, subcmd, opts, *args):
opts.state = 'all'

if opts.state == '':
opts.state = 'new,review'
opts.state = 'declined,new,review'

if args[0] == 'help':
return self.do_help(['help', 'request'])
Expand Down

0 comments on commit 4b44e74

Please sign in to comment.