Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote unicode characters in URL path #1020

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Mar 29, 2022

Also throw URLError if illegal characters are found in URL path.

Also throw URLError if illegal characters are found in URL path.
@dmach dmach added this to In progress in Networking via automation Mar 29, 2022
@pep8speaks
Copy link

Hello @dmach! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3337:5: E741 ambiguous variable name 'l'

@dmach
Copy link
Contributor Author

dmach commented Mar 29, 2022

Fixes #1018

I'd ignore the following pep8speaks warning in this case, because the l variable existed before submitting this pull request.

Line 3337:5: E741 ambiguous variable name 'l'

@lethliel
Copy link
Member

LGTM. Thanks for the fix.

@lethliel lethliel merged commit ee0773d into openSUSE:master Mar 30, 2022
Networking automation moved this from In progress to Done Mar 30, 2022
@marcus-h
Copy link
Member

marcus-h commented Mar 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants