Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build.get_repo() to return only directory that contains 'repodata/repomd.xml' #1307

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Apr 27, 2023

Fixes: #477

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 11.11% and no project coverage change.

Comparison is base (e25dc2d) 28.81% compared to head (2cdf052) 28.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   28.81%   28.82%           
=======================================
  Files          36       36           
  Lines       16639    16637    -2     
=======================================
+ Hits         4794     4795    +1     
+ Misses      11845    11842    -3     
Impacted Files Coverage Δ
osc/build.py 4.73% <0.00%> (+0.01%) ⬆️
osc/core.py 35.66% <ø> (ø)
osc/commandline.py 19.04% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmach
Copy link
Contributor Author

dmach commented Apr 28, 2023

Checked with @lethliel who reported the issue and he thinks the patch should be ok. Merging...

@dmach dmach merged commit 0ea0015 into openSUSE:master Apr 28, 2023
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build -p <dir> broken logic if dir/repodata/ is there but empty
1 participant