Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'diff' command to support diffing selected files only #1311

Merged
merged 3 commits into from Apr 28, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Apr 28, 2023

Fixes: #515

We probably want the retry on by default to retry on running services,
but in some cases such as osc diff it only adds delays while handling
a quite expected errror state.
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 78.26% and project coverage change: +0.04 🎉

Comparison is base (a08ab2e) 28.81% compared to head (80fc2bf) 28.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
+ Coverage   28.81%   28.86%   +0.04%     
==========================================
  Files          36       36              
  Lines       16639    16655      +16     
==========================================
+ Hits         4795     4807      +12     
- Misses      11844    11848       +4     
Impacted Files Coverage Δ
osc/commandline.py 19.03% <0.00%> (-0.01%) ⬇️
osc/grabber.py 44.82% <50.00%> (+1.97%) ⬆️
osc/core.py 35.73% <76.92%> (+0.07%) ⬆️
osc/connection.py 53.90% <100.00%> (+0.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmach dmach merged commit 651dc70 into openSUSE:master Apr 28, 2023
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osc diff -r... file is not limited to that file
1 participant