Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading password from keyring #1420

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix loading password from keyring #1420

merged 1 commit into from
Oct 4, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Oct 3, 2023

Fixes: #1419

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ee725ff) 30.38% compared to head (ce72ffb) 30.38%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   30.38%   30.38%           
=======================================
  Files          49       49           
  Lines       17698    17698           
=======================================
  Hits         5377     5377           
  Misses      12321    12321
Files Coverage Δ
osc/conf.py 52.67% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mcepl
mcepl approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@mcepl mcepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, fixes the problem for me. Thank you!

@dmach dmach force-pushed the fix-loading-password-from-keyring branch from 2c28bde to ce72ffb Compare October 3, 2023 07:12
@dmach dmach merged commit 11c2140 into openSUSE:master Oct 4, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcepl mcepl mcepl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Server returned an error: HTTP Error 401: Unauthorized
2 participants
@dmach @mcepl