Fix testing revision for being empty #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
+ Coverage 30.38% 30.40% +0.02%
==========================================
Files 49 49
Lines 17698 17708 +10
==========================================
+ Hits 5377 5384 +7
- Misses 12321 12324 +3
☔ View full report in Codecov by Sentry. |
Revision 0 is a valid value, but conditions evaluate it as False along with None and "". This change treats 0 as a proper revision.
dmach
force-pushed
the
fix-empty-revisions
branch
from
0bb7e89
to
386c4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revision 0 is a valid value, but evaluates as False the same way as None or "". This change threats 0 as a proper revision.