Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fix handling of "--yes" argument to "osc sr" #269

Merged
merged 1 commit into from
Feb 22, 2017

Conversation

srinidhibs
Copy link
Contributor

Passing --yes option to osc sr was still prompting for superseding existing submitrequests, if any. Added a small check to skip checking for existing requests if --yes is passed.

NOTE: I couldn't test if this change affects maintenance requests.

@marcus-h marcus-h merged commit b2b59ca into openSUSE:master Feb 22, 2017
@marcus-h
Copy link
Member

marcus-h commented Feb 22, 2017 via email

marcus-h added a commit that referenced this pull request Oct 6, 2017
This basically reverts commit b2b59ca, because the old code performed
a "no" instead of a "yes" (see also the discussion in
#269).

Fixes: #343 ("'osc sr --yes ...' doesn't supersede existing requests
       as promised")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants