some basic tests and fixed bug to display users #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @users = User.all(:joins => :person, | ||
| :order => "people.last_name ASC", | ||
| :select => "users.*, | ||
| @users = User.joins(:person).order("people.last_name ASC").select("users.*, |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
Please rebase and fix the remaining styling issues. Thanks |
| end | ||
| it "changes @contact's attributes" do | ||
| patch :update, id: user.id | ||
| expect(build(:user, email: 'example@incoherent.de', id: user.id).email).to eq('example@incoherent.de') |
… controller for displaying users Fixes by hounci violations
bear454
added a commit
that referenced
this pull request
Jun 3, 2014
some basic tests and fixed bug to display users
cycomachead
added a commit
to cycomachead/osem
that referenced
this pull request
Mar 10, 2022
Merge osem master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in admin/users controller to display users.
Some basic tests for admin/users controller.