Send mail on ticket confirmation with attached ticket pdf. #1600
Conversation
| @@ -0,0 +1,7 @@ | |||
| class AddTicketConfirmationToEmailSettings < ActiveRecord::Migration | |||
| def change | |||
| add_column :email_settings, :send_on_ticket_confirmation, :boolean, default: false | |||
There was a problem hiding this comment.
Do we really need all that?
I mean. I would say this email should always be sent. And I think we don't need to customize the message.
There was a problem hiding this comment.
And I think we don't need to customize the message.
So should we set the message manually or like use the same message that is sent in registration confirmation email?
There was a problem hiding this comment.
I would say this email should always be sent.
👍
There was a problem hiding this comment.
You can send a different email, but the subject can always be something like Your tickets for ConferenceName. So I mean that you can find a default message that can be used for all conferences, so the admin doesn't need to configure this. It is also less confusing for user, who will always receive similar email.
And in this way, you don't need to store anything in the DB. 😉
app/models/physical_ticket.rb
Outdated
|
|
||
| def send_ticket_confirmation_mail | ||
| if conference.email_settings.send_on_ticket_confirmation? | ||
| Mailbot.ticket_confirmation_mail(conference, user, self).deliver_later |
There was a problem hiding this comment.
We were talking about not sending two emails, as when paying the tickets there is an email already sent, what is the state of that?
There was a problem hiding this comment.
No unfortunately we cannot send the ticket as a attachment in stripe confirmation email. Customisation of stripe confirmation email is only limited to changing the organisation name, logo.
There was a problem hiding this comment.
so we will always send two emails in this case, right?
There was a problem hiding this comment.
Yes one for payment confirmation and the the other one for ticket confirmation.
siddhantbajaj
force-pushed
the
pdf-attachment
branch
3 times, most recently
from
bfa4aed
to
8241670
Compare
| @@ -0,0 +1,8 @@ | |||
| Dear <%= @user.name %>, | |||
|
|
|||
| Thanks! You have successfully booked a <%= @physical_ticket.ticket.title %> ticket for the event <%= @conference.title %>. | |||
There was a problem hiding this comment.
I would also add the token in the email
app/models/physical_ticket.rb
Outdated
| @@ -6,6 +6,7 @@ class PhysicalTicket < ActiveRecord::Base | |||
| has_many :ticket_scannings | |||
|
|
|||
| before_create :set_token | |||
| after_create :send_ticket_confirmation_mail | |||
There was a problem hiding this comment.
there is something I don't like with this. If you but 3 tickets, then we will send 3 different emails. I would instead send this email after creating the physical_tickets in one single email 🤔
Added mailer method to send ticket confirmation email along with the attached pdf for ticket.
siddhantbajaj
force-pushed
the
pdf-attachment
branch
from
8241670
to
906f08b
Compare
|
|
No description provided.