Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ticket purchase #1606

Merged
merged 2 commits into from Aug 22, 2017
Merged

Refactor ticket purchase #1606

merged 2 commits into from Aug 22, 2017

Conversation

siddhantbajaj
Copy link
Contributor

closes #1527

@siddhantbajaj
Copy link
Contributor Author

image

@siddhantbajaj
Copy link
Contributor Author

siddhantbajaj commented Jul 20, 2017 •
edited

@differentreality

Theoretically, a ticked_purchase can occur at any time (after the conference, after registration period is over, etc), as there is no ability limiting it.

True but in practical there is no way a ticket_purchase can be created after the registration period right? So should we really add a validation for this, if in case you meant to add a validation here.

At the ticket turnover distribution graph in admin/tickets#index, the amount of the turnover could be formatted into a more humanly readable way.

image
Would something like this work?

@Ana06 Ana06 merged commit 84522a9 into openSUSE:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor ticket purchases
2 participants
@siddhantbajaj @Ana06