Ajax datatable admin registrations #2189
Conversation
Supercedes openSUSE#2031 . Note: * "Questions" modals have been dropped from this view; questions are no longer asked on registration, since Surveys(PR#1100) were added.
bear454
force-pushed
the
ajax-datatable-admin-registrations
branch
from
8dd204a
to
f3a5759
Compare
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
- Coverage 82.22% 81.45% -0.78%
==========================================
Files 149 150 +1
Lines 4894 4944 +50
==========================================
+ Hits 4024 4027 +3
- Misses 870 917 +47
Continue to review full report at Codecov.
|
|
@hennevogel - review this already :P |
| %h3{id: 'question-modal-header'} | ||
| Questions for Foobar | ||
| .modal-body#question-modal-body | ||
| :javascript |
There was a problem hiding this comment.
I really think you should put this into a .js file in the asset pipeline...
There was a problem hiding this comment.
Yeah, I go back and forth on that... and here's what I've come up with:
- If it's used on one page, it belongs in that page.
- If it's used more than once, it should be in the asset pipeline.
There was a problem hiding this comment.
Yeah the only overhead you would generate people downloading those ~80 lines once :-D But okay
| %td{ 'data-order' => registration.attended.to_s } | ||
| = check_box_tag "#{@conference.short_title}_#{registration.id}", registration.id, registration.attended, | ||
| class: 'switch-checkbox', | ||
| url: toggle_attendance_admin_conference_registration_path(@conference.short_title, id: registration.id)+"?attended=" |
There was a problem hiding this comment.
@bear454 you have completed removed attendance from the registrations. Why?
There was a problem hiding this comment.
Because it's useless. It's not an effective sort, or filter, you can't get an overall count of it, and it's only set if you use one of the check-in methods (which are terrible upstream).
There was a problem hiding this comment.
I understand the concerns, however I don't agree with the removal. I am pretty sure there are some conferences using this feature.
I didn't expect a PR that aims to improve performance, to actually remove a feature we had :/
If this was discussed, I've clearly missed the conversation.
Short description of what this resolves/which issues does this fix?:
Changes proposed in this pull request: