-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display emails to organizers #2549
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 76.46% 76.25% -0.22%
==========================================
Files 146 146
Lines 4810 4830 +20
==========================================
+ Hits 3678 3683 +5
- Misses 1132 1147 +15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 82.21% 81.72% -0.49%
==========================================
Files 146 146
Lines 4773 4804 +31
==========================================
+ Hits 3924 3926 +2
- Misses 849 878 +29
Continue to review full report at Codecov.
|
ea778df
to
ebf7972
Compare
Hm this might sound a bit harsh as I don't have any idea about your GSoC plans but why are we implementing mail functionality in our web app? There are plenty of ways people can send email. |
@hennevogel Thanks for the comment 😄 .Yes, you are right. But I proposed this so that organizers can inform people about some sudden changes or with an update about the conference. |
That's as simple as <a href="mailto:onecooldude@gmail.com?subject=Hey+Dude.+You're+Cool.&cc=anotherdude@gmail.com,thirddude@gmail.com,fourthdude@gmail.com&bcc=invisibledude@gmail.com,ghost@gmail.com">Contact Organizers</a> and we don't have to worry about all the follow up features your mail interface will not support, like different formats (text/plain vs. html), BCC or other custom headers, special formatting of the text. The list of MUA features is endless. |
@hennevogel thank you 😄 . That's indeed very simple, didn't think of this approach 😓 . I will update the PR. Thanks. |
d08d19d
to
e2410f8
Compare
303601b
to
ef7001f
Compare
cc832c5
to
e572428
Compare
Codecov Report
@@ Coverage Diff @@
## GSoC19 #2549 +/- ##
==========================================
- Coverage 82.26% 81.96% -0.31%
==========================================
Files 147 147
Lines 4799 4818 +19
==========================================
+ Hits 3948 3949 +1
- Misses 851 869 +18
Continue to review full report at Codecov.
|
65b33b3
to
da75406
Compare
I like the fact that we are able to further add/deselect emails from the list! What we aim to do here is to automatically send an email to all accepted booths (we already have an Email template for that). The scenario is the following:
|
@keys['Registered Users'] = @conference.participants.pluck(:email) if @conference.participants.present? | ||
@keys['Confirmed Tracks'] = User.find(confirmed_track_ids.uniq).pluck(:email) if confirmed_track_ids.present? | ||
@keys['Supporters'] = @conference.supporters.pluck(:email) if @conference.supporters.present? | ||
@keys['Organizers'] = roles_ids['organizer'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be Conference Organizers
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
@differentreality Sending email to everyone after the deadline can be implemented in separate PR. |
user can write any email in the field
on selecting an option, emails will be displayed in the field
2aeb76f
to
234defc
Compare
Codecov Report
@@ Coverage Diff @@
## GSoC19 #2549 +/- ##
==========================================
- Coverage 82.26% 81.96% -0.31%
==========================================
Files 147 147
Lines 4799 4818 +19
==========================================
+ Hits 3948 3949 +1
- Misses 851 869 +18
Continue to review full report at Codecov.
|
Closing this for lack of activity... |
Checklist
master
branch.NEED
If organizers want to contact a user, they can get the user's email from user's profile and can contact through mail. This is okay if they want to contact 1 or 2 users.
But what if they want to contact a group of people associated with the conference. For such scenario,
the only option available to them is to find emails of all users and then contact them.
With this PR, Organizers will get the emails of the group of people they want to contact say (subscribers, booth responsibles etc.). They just have to select the group and proceed with the link which will open their default mail service with email already entered for them. Now they just have to enter subject and body.
This way organizers can save a lot of time in finding people to contact.
WORKFLOW
sidebar link
![main2](https://user-images.githubusercontent.com/25618739/61477674-6a567c80-a9ad-11e9-9c48-7d95b847f6a4.png)
form
![main1](https://user-images.githubusercontent.com/25618739/61477695-77736b80-a9ad-11e9-8257-14a78c3a4127.png)
options
![options](https://user-images.githubusercontent.com/25618739/61477776-a689dd00-a9ad-11e9-983d-acd615f7077a.png)
selecting options
![main3](https://user-images.githubusercontent.com/25618739/61477719-865a1e00-a9ad-11e9-8987-1d5d72cc4520.png)
redirected to mail
![main4](https://user-images.githubusercontent.com/25618739/61477736-8eb25900-a9ad-11e9-8fb7-ec10350f9bea.png)