Display emails to organizers #2549

rahul2240 · 2019-07-11T15:44:18Z

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the upstream master branch.
The tests pass locally with my changes.
I have added tests that prove my fix is effective or that my feature works(if appropriate).
I have added necessary documentation (if appropriate).

NEED

If organizers want to contact a user, they can get the user's email from user's profile and can contact through mail. This is okay if they want to contact 1 or 2 users.
But what if they want to contact a group of people associated with the conference. For such scenario,
the only option available to them is to find emails of all users and then contact them.

With this PR, Organizers will get the emails of the group of people they want to contact say (subscribers, booth responsibles etc.). They just have to select the group and proceed with the link which will open their default mail service with email already entered for them. Now they just have to enter subject and body.

This way organizers can save a lot of time in finding people to contact.

WORKFLOW

Organizers will go to send emails link available in sidebar.
Select the right group or enter email ids if they want to in the text field.
Press the send email button.
User will be redirected to the default mail with emails in bcc.

sidebar link

form

options

selecting options

redirected to mail

codecov · 2019-07-11T17:51:41Z

Codecov Report

Merging #2549 into master will decrease coverage by 0.21%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
- Coverage   76.46%   76.25%   -0.22%     
==========================================
  Files         146      146              
  Lines        4810     4830      +20     
==========================================
+ Hits         3678     3683       +5     
- Misses       1132     1147      +15

Impacted Files	Coverage Δ
app/controllers/admin/emails_controller.rb	`40.62% <16.66%> (-30.81%)`	⬇️
app/mailers/mailbot.rb	`48.93% <50%> (+0.04%)`	⬆️
app/helpers/format_helper.rb	`58.33% <0%> (+0.92%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b12830...6c70de9. Read the comment docs.

codecov · 2019-07-11T17:51:42Z

Codecov Report

Merging #2549 into master will decrease coverage by 0.48%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
- Coverage   82.21%   81.72%   -0.49%     
==========================================
  Files         146      146              
  Lines        4773     4804      +31     
==========================================
+ Hits         3924     3926       +2     
- Misses        849      878      +29

Impacted Files	Coverage Δ
app/controllers/admin/emails_controller.rb	`31.11% <3.22%> (-61.75%)`	⬇️
app/controllers/commercials_controller.rb	`96.42% <0%> (+3.57%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ad952...e572428. Read the comment docs.

hennevogel · 2019-07-17T14:14:42Z

Hm this might sound a bit harsh as I don't have any idea about your GSoC plans but why are we implementing mail functionality in our web app? There are plenty of ways people can send email.

rahul2240 · 2019-07-17T15:46:52Z

@hennevogel Thanks for the comment 😄 .Yes, you are right. But I proposed this so that organizers can inform people about some sudden changes or with an update about the conference.
It has its own advantage i.e organizers can contact the right group of people instantly.
There are plenty of ways to send email but my purpose for this feature is to provide a custom template to organizers for a given audience in regard to the particular conference.

hennevogel · 2019-07-17T15:55:33Z

It has its own advantage i.e organizers can contact the right group of people instantly.

That's as simple as

<a href="mailto:onecooldude@gmail.com?subject=Hey+Dude.+You're+Cool.&cc=anotherdude@gmail.com,thirddude@gmail.com,fourthdude@gmail.com&bcc=invisibledude@gmail.com,ghost@gmail.com">Contact Organizers</a>

and we don't have to worry about all the follow up features your mail interface will not support, like different formats (text/plain vs. html), BCC or other custom headers, special formatting of the text. The list of MUA features is endless.

rahul2240 · 2019-07-17T17:06:16Z

@hennevogel thank you 😄 . That's indeed very simple, didn't think of this approach 😓 . I will update the PR. Thanks.

codecov-io · 2019-07-20T15:04:21Z

Codecov Report

Merging #2549 into GSoC19 will decrease coverage by 0.3%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##           GSoC19    #2549      +/-   ##
==========================================
- Coverage   82.26%   81.96%   -0.31%     
==========================================
  Files         147      147              
  Lines        4799     4818      +19     
==========================================
+ Hits         3948     3949       +1     
- Misses        851      869      +18

Impacted Files	Coverage Δ
app/controllers/admin/emails_controller.rb	`42.42% <5.26%> (-50.44%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2f2b5...234defc. Read the comment docs.

app/views/admin/emails/custom_email.html.haml

differentreality · 2019-08-09T10:30:51Z

I like the fact that we are able to further add/deselect emails from the list!

What we aim to do here is to automatically send an email to all accepted booths (we already have an Email template for that). The scenario is the following:

Evaluate Booth proposals
Start accepting booths (for some you are certain, for some others not), some booths are already marked as accepted
Some booth proposals are to_accept (meaning we think about accepting them, but let's see if we can fit them all)
After the deadline (and after we have finalized our selections) we want to send out an email to everyone to let them know if their proposal was accepted or rejected

differentreality · 2019-08-09T10:26:16Z

app/controllers/admin/emails_controller.rb

+      @keys['Registered Users'] = @conference.participants.pluck(:email) if @conference.participants.present?
+      @keys['Confirmed Tracks'] = User.find(confirmed_track_ids.uniq).pluck(:email) if confirmed_track_ids.present?
+      @keys['Supporters'] = @conference.supporters.pluck(:email) if @conference.supporters.present?
+      @keys['Organizers'] = roles_ids['organizer']


That should be Conference Organizers, right?

rahul2240 · 2019-08-16T09:41:02Z

@differentreality Sending email to everyone after the deadline can be implemented in separate PR.
The purpose of this PR is that organizers can contact a group of people and inform them about anything i.e either updating them with some news or important announcement or something. I think its an important feature for improving communication between organizers and people.

user can write any email in the field

on selecting an option, emails will be displayed in the field

codecov · 2019-08-16T09:53:06Z

Codecov Report

Merging #2549 into GSoC19 will decrease coverage by 0.3%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##           GSoC19    #2549      +/-   ##
==========================================
- Coverage   82.26%   81.96%   -0.31%     
==========================================
  Files         147      147              
  Lines        4799     4818      +19     
==========================================
+ Hits         3948     3949       +1     
- Misses        851      869      +18

Impacted Files	Coverage Δ
app/controllers/admin/emails_controller.rb	`42.42% <5.26%> (-50.44%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2f2b5...234defc. Read the comment docs.

hennevogel · 2022-05-13T15:04:55Z

Closing this for lack of activity...

rahul2240 force-pushed the custom_email branch from dbf8c87 to 6c70de9 Compare July 11, 2019 17:51

rahul2240 force-pushed the custom_email branch from 6c70de9 to ac42608 Compare July 11, 2019 18:13

rahul2240 added the GSoC GSoC 19 related issues/PR label Jul 13, 2019

rahul2240 force-pushed the custom_email branch 2 times, most recently from ea778df to ebf7972 Compare July 14, 2019 11:46

rahul2240 force-pushed the custom_email branch 2 times, most recently from d08d19d to e2410f8 Compare July 18, 2019 17:10

rahul2240 changed the title ~~Custom email for admins [WIP]~~ display emails to organizers [WIP] Jul 18, 2019

initialize route and form for displaying emails

3f35d82

rahul2240 force-pushed the custom_email branch 3 times, most recently from 303601b to ef7001f Compare July 19, 2019 09:33

rahul2240 changed the title ~~display emails to organizers [WIP]~~ Display emails to organizers Jul 19, 2019

rahul2240 force-pushed the custom_email branch 3 times, most recently from cc832c5 to e572428 Compare July 20, 2019 15:04

rahul2240 force-pushed the custom_email branch 2 times, most recently from 65b33b3 to da75406 Compare July 20, 2019 15:14

rahul2240 changed the base branch from master to GSoC19 July 21, 2019 09:30

differentreality reviewed Jul 21, 2019

View reviewed changes

app/views/admin/emails/custom_email.html.haml Outdated Show resolved Hide resolved

rahul2240 force-pushed the custom_email branch from da75406 to 2aeb76f Compare July 22, 2019 09:01

differentreality reviewed Aug 9, 2019

View reviewed changes

rahul2240 added 4 commits August 16, 2019 15:16

create hash with key as group name and values as emails

d8970f0

user can enter emails

6cc2efd

user can write any email in the field

values are now visible in text field

2141993

on selecting an option, emails will be displayed in the field

add mailing option in form

234defc

rahul2240 force-pushed the custom_email branch from 2aeb76f to 234defc Compare August 16, 2019 09:46

differentreality self-assigned this Jan 6, 2020

hennevogel closed this May 13, 2022

AndrewKvalheim mentioned this pull request Mar 5, 2023

Send useful emails to visitors #105

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display emails to organizers #2549

Display emails to organizers #2549

rahul2240 commented Jul 11, 2019 •

edited

Loading

codecov bot commented Jul 11, 2019

codecov bot commented Jul 11, 2019 •

edited

Loading

hennevogel commented Jul 17, 2019

rahul2240 commented Jul 17, 2019

hennevogel commented Jul 17, 2019

rahul2240 commented Jul 17, 2019

codecov-io commented Jul 20, 2019 •

edited by codecov bot

Loading

differentreality commented Aug 9, 2019

differentreality Aug 9, 2019

rahul2240 Aug 9, 2019

rahul2240 commented Aug 16, 2019 •

edited

Loading

codecov bot commented Aug 16, 2019 •

edited

Loading

hennevogel commented May 13, 2022

Display emails to organizers #2549

Display emails to organizers #2549

Conversation

rahul2240 commented Jul 11, 2019 • edited Loading

codecov bot commented Jul 11, 2019

Codecov Report

codecov bot commented Jul 11, 2019 • edited Loading

Codecov Report

hennevogel commented Jul 17, 2019

rahul2240 commented Jul 17, 2019

hennevogel commented Jul 17, 2019

rahul2240 commented Jul 17, 2019

codecov-io commented Jul 20, 2019 • edited by codecov bot Loading

Codecov Report

differentreality commented Aug 9, 2019

differentreality Aug 9, 2019

Choose a reason for hiding this comment

rahul2240 Aug 9, 2019

Choose a reason for hiding this comment

rahul2240 commented Aug 16, 2019 • edited Loading

codecov bot commented Aug 16, 2019 • edited Loading

Codecov Report

hennevogel commented May 13, 2022

rahul2240 commented Jul 11, 2019 •

edited

Loading

codecov bot commented Jul 11, 2019 •

edited

Loading

codecov-io commented Jul 20, 2019 •

edited by codecov bot

Loading

rahul2240 commented Aug 16, 2019 •

edited

Loading

codecov bot commented Aug 16, 2019 •

edited

Loading