Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in test of animated form #2662

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

AndrewKvalheim
Copy link
Member

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

I'm still seeing #2356 intermittently.

Changes proposed in this pull request

Until #2661 is resolved, accommodate the problematic animation.

AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2020
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request May 31, 2020
The help text for the event type field is animated using a technique
unaffected by `Capybara.disable_animation`. Wait for the animation.

Resolves: openSUSE#2356
Works around: openSUSE#2661
@hennevogel hennevogel merged commit 7f1d3b9 into openSUSE:master Mar 6, 2021
@AndrewKvalheim AndrewKvalheim deleted the issue-2661-workaround branch June 13, 2021 19:27
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request Mar 10, 2023
Incidentally fulfills the name need as openSUSE#2662
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request Mar 11, 2023
Incidentally fulfills the same need as openSUSE#2662
AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this pull request Mar 11, 2023
Incidentally fulfills the same need as openSUSE#2662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants