Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct invalid table markup #3133

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Correct invalid table markup #3133

merged 1 commit into from
Apr 19, 2023

Conversation

AndrewKvalheim
Copy link
Member

@AndrewKvalheim AndrewKvalheim commented Mar 5, 2023 •
edited
Loading

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the upstream master branch.
  • The tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).

Short description of what this resolves

Many views nest th elements directly within thead, but thead may only contain tr elements.

Related: #1472

Changes proposed in this pull request

Add the required tr elements. While we’re at it, add a few implicit tbody elements for consistency.

(Best viewed with whitespace hidden)

@AndrewKvalheim
Correct invalid table markup
1f31c1c 
  - Add required <tr> within <thead>
  - Add implicit <tbody> after <thead>
@hennevogel hennevogel merged commit 3aaf860 into openSUSE:master Apr 19, 2023
@AndrewKvalheim AndrewKvalheim deleted the thead-tr branch May 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hennevogel hennevogel hennevogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewKvalheim @hennevogel