Fix cfp create and error display #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @conference.short_title), | ||
| notice: 'Call for Papers was successfully updated.') | ||
| else | ||
| flash.now[:error] = 'Call for Papers update failed. ' + @cfp.errors.full_messages.map {|e| e.humanize + "."}.join(" ") |
There was a problem hiding this comment.
Line is too long. [124/80]
Space between { and | missing.
Space missing inside }.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| notice: 'Call for Papers was successfully updated.') | ||
| else | ||
| flash.now[:error] = 'Call for Papers update failed. ' + | ||
| @cfp.errors.full_messages.map { |e| e.humanize + '.' }.join(' ') |
There was a problem hiding this comment.
Line is too long. [84/80]
Tab detected.
| id: @conference.short_title), | ||
| error: 'Call for Papers failed.') | ||
| flash.now[:error] = 'Call for Papers creation failed. ' + | ||
| @cfp.errors.full_messages.map { |e| e.humanize + '.' }.join(' ') |
|
Please rebase |
|
This is done differently in pull #117 now |
cycomachead
added a commit
to cycomachead/osem
that referenced
this pull request
Mar 10, 2022
…ild-on-travis-🍊🍊 Why the heck cant i build on travis 🍊🍊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also closes #69