Fixed /admin/users #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArgumentError in Admin::UsersController#index wrong number of arguments (1 for 0) Rails 4 has depricated "all" method, now it's default behaviour
| end | ||
| people.email AS email").joins(:person).load.order("people.last_name ASC") | ||
|
|
||
| end |
There was a problem hiding this comment.
end at 11, 1 is not aligned with def at 4, 2
| people.last_name AS last_name, | ||
| people.first_name AS first_name, | ||
| people.public_name AS public_name, | ||
| people.email AS email") | ||
| people.email AS email'). | ||
| joins(:person).load.order('people.last_name ASC') |
|
I would go even further - because rails does not require you to select columns - the whole select can be like @users = User.joins(:person).order('people.last_name ASC')and to User model user.rb after line 18 delegate :last_name, :first_name, :public_name, :to => :person |
| @@ -17,6 +17,8 @@ class User < ActiveRecord::Base | |||
| before_save :setup_role | |||
| before_create :create_person | |||
|
|
|||
| delegate :last_name, :first_name, :public_name, :email, to: :person | |||
There was a problem hiding this comment.
@alter please remove :email here as it should be user's method, not delegated to person
cycomachead
added a commit
to cycomachead/osem
that referenced
this pull request
Mar 10, 2022
….5.0 Update codecov: 0.2.11 → 0.5.0 (major)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgumentError in Admin::UsersController#index
wrong number of arguments (1 for 0)
Rails 4 has depricated "all" method, now it's default behaviour
POC: http://stackoverflow.com/questions/18203712/rails-4-relationall-deprecation