Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scripts fix #105

Merged
merged 1 commit into from Aug 6, 2019
Merged

No scripts fix #105

merged 1 commit into from Aug 6, 2019

Conversation

iyuroch
Copy link
Contributor

@iyuroch iyuroch commented Sep 28, 2018

Add if statement in jinja to see if there are scripts.
If there is are no scripts - continue.

@sebix
Copy link
Contributor

sebix commented Oct 3, 2018

Fail in the tests:

TemplateAssertionError: no test named 'None'

I guess that the tests would still fail if the above is fixed as you added two newlines.

@toabctl
Copy link
Member

toabctl commented May 13, 2019

Can you squash your commits please?

@sebix
Copy link
Contributor

sebix commented Jul 28, 2019

@toabctl After a merge with master, the tests are succeeding

Copy link
Member

@toabctl toabctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis is still failing

@sebix
Copy link
Contributor

sebix commented Aug 5, 2019

8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail?

@toabctl
Copy link
Member

toabctl commented Aug 5, 2019

8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail?

Travis - See the box bellow the merge button (this link: https://travis-ci.org/openSUSE/py2pack/builds/539254302?utm_source=github_status&utm_medium=notification )

@toabctl
Copy link
Member

toabctl commented Aug 5, 2019

Maybe a rebase is needed to include the date fixes for the spec templates?

@sebix
Copy link
Contributor

sebix commented Aug 5, 2019

@toabctl
Either:
First @iyuroch merges in master, then you merge the PR
Or:
You merge the PR

Result is the smae

@toabctl
Copy link
Member

toabctl commented Aug 5, 2019

@sebix hm. I can't follow. Travis is red and imo it should be fixed before merging anything. Is there already a fix for that somewhere?

@sebix
Copy link
Contributor

sebix commented Aug 5, 2019

Is there already a fix for that somewhere?

master

@toabctl
Copy link
Member

toabctl commented Aug 5, 2019

master

then why is travis still red here?

@sebix
Copy link
Contributor

sebix commented Aug 5, 2019

master

then why is travis still red here?

Because it only checks the PR itself, not it's merge in master. However, it could be configured to also check the merge ("pull").

@toabctl
Copy link
Member

toabctl commented Aug 5, 2019

@sebix a rebase should be enough. @iyuroch could you do that please?

@toabctl
Copy link
Member

toabctl commented Aug 6, 2019

tests executed locally - works. thanks!

@toabctl toabctl merged commit a060a31 into openSUSE:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants