New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No scripts fix #105
No scripts fix #105
Conversation
Fail in the tests:
I guess that the tests would still fail if the above is fixed as you added two newlines. |
Can you squash your commits please? |
@toabctl After a merge with master, the tests are succeeding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis is still failing
8 days ago I tested the merge of this branch with master and it worked (because master had the tes fixes). @toabctl can you please specify what does still fail? |
Travis - See the box bellow the merge button (this link: https://travis-ci.org/openSUSE/py2pack/builds/539254302?utm_source=github_status&utm_medium=notification ) |
Maybe a rebase is needed to include the date fixes for the spec templates? |
@sebix hm. I can't follow. Travis is red and imo it should be fixed before merging anything. Is there already a fix for that somewhere? |
master |
then why is travis still red here? |
Because it only checks the PR itself, not it's merge in master. However, it could be configured to also check the merge ("pull"). |
tests executed locally - works. thanks! |
Add if statement in jinja to see if there are scripts.
If there is are no scripts - continue.