Libalternatives support #115

schubi2 · 2021-09-28T14:08:23Z

Please have a look to the README.md how the patch supports the new libalternatives too.

bnavigator

Do you have any demo packages where this works?

README.md

bnavigator · 2021-09-29T08:43:30Z

flavor.in

+    print(rpm.expand("%ghost %{_datadir}/libalternatives/" .. name .. "/%python_version_nodots.conf\\\n")) \
+    print(rpm.expand("%ghost %{_datadir}/libalternatives/" .. name .. "/10%python_version_nodots.conf\\\n")) \


This does not look right. It's either one or the other, but not both files for any flavor. Have a look at the prio variable in python_install_alternative.

Also, the Python 3.10 flavor, once it is primary (not that soon I guess), it will have a prio of 1310, not 10310.

At least it is not really nice :-) I have fixed it.

mcepl

Generally I don't see any serious problems, aside from what Ben noticed.

README.md

flavor.in

schubi2 · 2021-09-30T06:18:42Z

schubi2 · 2021-09-30T07:23:25Z

If you want I can continue with the other packages and after I have converted and tested them we are quite sure that it is working and can merge the PR after it.

schubi2 · 2021-10-01T08:28:42Z

I have changed and tested all mentioned packages without a problem. Could we please finish this PR in order to submit all these packages ?

README.md

bnavigator · 2021-10-01T08:38:51Z

Currently I am testing with following packages:
python-tempora - simple example
python-evtx - has multiple calls
python-ipython - has man pages and group settings

Where is the obs repo demonstrating it? home:schubi2 does not have your modified python-rpm-macros and none of the above packages' specfiles look like they already fully use the macros.

schubi2 · 2021-10-01T10:05:37Z

I have pushed all my changes to home:schubi2.
https://build.opensuse.org/package/show/home:schubi2/python-rpm-macros
https://build.opensuse.org/package/show/home:schubi2/python-evtx
https://build.opensuse.org/package/show/home:schubi2/python-ipython
https://build.opensuse.org/package/show/home:schubi2/python-tempora
And the rest of the 30 packages....

bnavigator · 2021-10-01T10:44:25Z

I have pushed all my changes to home:schubi2.
https://build.opensuse.org/package/show/home:schubi2/python-rpm-macros

Okay, I see. The service file and the version 20210929.eccf3f2 are not correct, you modified the files manually. Still not in the state of the current PR. You could adjust your _service to fetch from your PR branch.

https://build.opensuse.org/package/show/home:schubi2/python-evtx

rpmlint is not happy:

[  300s] python36-evtx.noarch: E: update-alternatives-requirement-missing
[  300s] python38-evtx.noarch: E: update-alternatives-requirement-missing
[  300s] python39-evtx.noarch: E: update-alternatives-requirement-missing
[  300s] The package does not have update-alternatives in Requires(post) or
[  300s] Requires(postun). This is needed for the proper scriptlet execution.
[  300s] 
[  300s] python36-evtx.noarch: E: update-alternatives-post-call-missing
[  300s] python38-evtx.noarch: E: update-alternatives-post-call-missing
[  300s] python39-evtx.noarch: E: update-alternatives-post-call-missing
[  300s] The package does not call update-alternatives --install in post phase to
[  300s] install all the configuration.
[  300s]

https://build.opensuse.org/package/show/home:schubi2/python-ipython

same

https://build.opensuse.org/package/show/home:schubi2/python-tempora

Why does the 15.3 build fail? It does not fail in d:l:p.
egg-info version is lost. Is it due to a libalternative related change in a package in the build dep tree?

bnavigator · 2021-10-01T11:01:12Z

rpmlint is not happy:

> rpm -q --scripts python38-evtx-0.6.1-31.1.noarch.rpm
warning: python38-evtx-0.6.1-31.1.noarch.rpm: Header V3 RSA/SHA256 Signature, key ID 3d51bceb: NOKEY
preinstall scriptlet (using /bin/sh):
# If libalternatives is used: Removing old update-alternatives entries.
for c in dump dump_chunk_slack eid_record_numbers extract_record filter_records info record_structure structure templates; do
  

if [ 1 -eq 1 ] ; then 
if [ "$1" -gt 0 ] && [ -f /usr/sbin/update-alternatives ]; then 
    update-alternatives --quiet --remove "evtx_$c.py" "/usr/bin/evtx_$c.py-3.8" 
fi 
fi 

done
postinstall scriptlet (using /bin/sh):
for c in dump dump_chunk_slack eid_record_numbers extract_record filter_records info record_structure structure templates; do
   
mkdir -p /usr/share/libalternatives/evtx_$c.py
echo binary=/usr/bin/evtx_$c.py-3.8 >/usr/share/libalternatives/evtx_$c.py/1038.conf
echo group=evtx_$c.py >>/usr/share/libalternatives/evtx_$c.py/1038.conf

done
postuninstall scriptlet (using /bin/sh):
for c in dump dump_chunk_slack eid_record_numbers extract_record filter_records info record_structure structure templates; do
  

if [ ! -e "/usr/bin/evtx_$c.py-3.8" ] && [ -f /usr/sbin/update-alternatives ]; then 
    update-alternatives --quiet --remove "evtx_$c.py" "/usr/bin/evtx_$c.py-3.8" 
fi 

done

You have to either adjust rpmlint or not install any update-alternatives call into %post and %postun at all.

https://github.com/rpm-software-management/rpmlint/blob/90c84aede91f999c4b4cbd0c3c73d5aa96f54f0f/rpmlint/checks/AlternativesCheck.py#L130

README.md

mcepl · 2021-10-01T14:41:38Z

@schubi2 Thank you very much and please submit the request to Factory from the current master.

schubi2 · 2021-10-01T14:45:43Z

Thank you ! But I will also have a look to the rpm-lint. Perhaps we can make it nicer there :-)

schubi2 added 10 commits September 27, 2021 13:14

test

125d9a8

test

2419ea4

using libalternatives

e7ccd6b

added docu

d1ac402

added docu

495e1d2

added docu

77f4bc7

added docu

cdbc1cc

handling mutiple arguments

b28d011

fixed termination

1ebff05

added BuildRequires to README

d607892

bnavigator reviewed Sep 29, 2021

View reviewed changes

mcepl requested changes Sep 29, 2021

View reviewed changes

README.md Show resolved Hide resolved

adapted suggestions

98c3255

bnavigator reviewed Sep 29, 2021

View reviewed changes

flavor.in Outdated Show resolved Hide resolved

function for evaluating priority

27b8332

bnavigator reviewed Oct 1, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

typo

758e6d8

bnavigator reviewed Oct 1, 2021

View reviewed changes

README.md Show resolved Hide resolved

mcepl approved these changes Oct 1, 2021

View reviewed changes

mcepl merged commit fc6c04e into openSUSE:master Oct 1, 2021

bnavigator mentioned this pull request Oct 3, 2021

rpmlint is not happy with the current libalternatives handling #116

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Libalternatives support #115

Libalternatives support #115

schubi2 commented Sep 28, 2021

bnavigator left a comment

bnavigator Sep 29, 2021

schubi2 Sep 29, 2021

mcepl left a comment

schubi2 commented Sep 30, 2021 •

edited

Loading

schubi2 commented Sep 30, 2021

schubi2 commented Oct 1, 2021

bnavigator commented Oct 1, 2021

schubi2 commented Oct 1, 2021

bnavigator commented Oct 1, 2021 •

edited

Loading

bnavigator commented Oct 1, 2021

mcepl commented Oct 1, 2021

schubi2 commented Oct 1, 2021

		print(rpm.expand("%ghost %{_datadir}/libalternatives/" .. name .. "/%python_version_nodots.conf\\\n")) \
		print(rpm.expand("%ghost %{_datadir}/libalternatives/" .. name .. "/10%python_version_nodots.conf\\\n")) \

Libalternatives support #115

Libalternatives support #115

Conversation

schubi2 commented Sep 28, 2021

bnavigator left a comment

Choose a reason for hiding this comment

bnavigator Sep 29, 2021

Choose a reason for hiding this comment

schubi2 Sep 29, 2021

Choose a reason for hiding this comment

mcepl left a comment

Choose a reason for hiding this comment

schubi2 commented Sep 30, 2021 • edited Loading

schubi2 commented Sep 30, 2021

schubi2 commented Oct 1, 2021

bnavigator commented Oct 1, 2021

schubi2 commented Oct 1, 2021

bnavigator commented Oct 1, 2021 • edited Loading

bnavigator commented Oct 1, 2021

mcepl commented Oct 1, 2021

schubi2 commented Oct 1, 2021

schubi2 commented Sep 30, 2021 •

edited

Loading

bnavigator commented Oct 1, 2021 •

edited

Loading