Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expand macros, just print them unexpanded #45

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Do not expand macros, just print them unexpanded #45

merged 2 commits into from
Jun 3, 2020

Conversation

mcepl
Copy link
Contributor

@mcepl mcepl commented Jun 2, 2020

(for %pytest* and %pyproject* macros)

Also, write them in multiline more readable manner.

If anybody refactor shared code to special function/macro, I am all ears.

@mcepl mcepl requested a review from scarabeusiv June 2, 2020 20:32
mcepl added 2 commits June 2, 2020 22:39
…yproject* macros)

Also, write them in multiline more readable manner.
@mcepl
Copy link
Contributor Author

mcepl commented Jun 3, 2020

From test on SLE-12:

abuild@stitny:/usr/src/packages/BUILD/python-rpm-macros> rpm --macros=macros.python_all -E "%pytest"
error: Macro %python_subpackages has unterminated body
%{python_expand PYTHONPATH=%{buildroot}%{$python_sitelib} PYTHONDONTWRITEBYTECODE=1 pytest-%{$python_bin_suffix} --ignore=_build.python2 --ignore=_build.python3 --ignore=_build.pypy3 -v }
abuild@stitny:/usr/src/packages/BUILD/python-rpm-macros>

No idea about that %python_subpackages macro, I haven’t changed anything there.

Copy link
Contributor

@scarabeusiv scarabeusiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcepl mcepl merged commit 503823c into openSUSE:master Jun 3, 2020
@mcepl mcepl deleted the rewrite_pytest branch June 3, 2020 08:15
bnavigator added a commit to bnavigator/python-rpm-macros that referenced this pull request Jun 23, 2020
bnavigator added a commit to bnavigator/python-rpm-macros that referenced this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants