New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init process of using embargoed field for Incidents #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests still need to be adapted.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the wrong place. It should be incidents and not openQA jobs.
Because of usage of same data structures in two independent applications (qem-bot and qem-dashboard) we need to do introduction of new field in several stages. At first stage we will start pushing this field into qem-dashboard from qem-bot. So after deploying this we can than read propely this field coming from bot
170bf42
to
9f57a96
Compare
yes you are correct . Is it right place now ? |
sorry not fully aware about workflows used in this project , so please don't get this as me trying to push you . But if there anything on me that is blocking this PR to be merged ? |
Nothing needs to be done by you. This just needs at least a second person reviewing and approving this PR whenever they find their github pull request review time. As the last update was on Friday and we are just in the middle of the next usual business day, i.e. Monday, I wouldn't be concerned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does look like the right place.
Because of usage of same data structures in two independent applications (qem-bot and qem-dashboard)
we need to do introduction of new field in several stages. At first stage we will start pushing
this field into qem-dashboard from qem-bot. So after deploying this we can than read propely
this field coming from bot