Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch compression for binary package payloads to Zstandard #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Conan-Kudo
Copy link
Member

Since openSUSE Leap 15.2 can read and install RPMs using Zstandard compression,
we can make the switch in Factory, as Fedora has done.

Cf. https://fedoraproject.org/wiki/Changes/Switch_RPMs_to_zstd_compression

Resolves #11

Since openSUSE Leap 15.2 can read and install RPMs using Zstandard compression,
we can make the switch in Factory, as Fedora has done.

Cf. https://fedoraproject.org/wiki/Changes/Switch_RPMs_to_zstd_compression
@marxin
Copy link
Contributor

marxin commented Jun 1, 2020

We've got a local patch that needs to be updated:
https://build.opensuse.org/request/show/777337

@Conan-Kudo
Copy link
Member Author

Please don't put it in the RPM package. The whole point of this package is to stop shipping changes as patches on RPM itself!

@marxin
Copy link
Contributor

marxin commented Jun 1, 2020

You are completely right.
What can we do @mlschroe about it?

@Conan-Kudo
Copy link
Member Author

@marxin Close that SR, make a new one to remove the change we do to macrosin.diff to do xz compression and then we can merge this PR. That lets us decrease the delta on RPM and still do the transition to Zstd compression.

@marxin
Copy link
Contributor

marxin commented Jun 1, 2020

@marxin Close that SR, make a new one to remove the change we do to macrosin.diff to do xz compression and then we can merge this PR. That lets us decrease the delta on RPM and still do the transition to Zstd compression.

@mls: Are you fine with the suggested approach?

@marxin
Copy link
Contributor

marxin commented Jun 1, 2020

@mls: Are you fine with the suggested approach?

Sorry: @mlschroe

@Vogtinator
Copy link
Member

Currently Tumbleweed supports online upgrade from Leap 15.0 and on, which this would break.

@marxin
Copy link
Contributor

marxin commented Jul 8, 2020

Note that the very same changes was accepted to Base:System/rpm:
https://build.opensuse.org/request/show/777337

@Vogtinator: If I'm correctly informed, we support update from the latest Leap (15.2) to Tumbleweed.
That's supported correctly

@Vogtinator
Copy link
Member

openQA also tests online updates from 42.1 with success currently, those would need to be dropped.
15.1 is not EOL yet, so definitely also supported for online upgrades to TW.

@mlschroe Was zstd support backported all the way back to 15.0 or just 15.2?

@marxin
Copy link
Contributor

marxin commented Jul 8, 2020

openQA also tests online updates from 42.1 with success currently, those would need to be dropped.

Good to know. We have to inform them then.

15.1 is not EOL yet, so definitely also supported for online upgrades to TW.

Yep, but one should first update to 15.2. That was what I was told by @scarabeusiv.

@mlschroe Was zstd support backported all the way back to 15.0 or just 15.2?

Just 15.2, it's not present in 15.1.

@Vogtinator
Copy link
Member

15.1 is not EOL yet, so definitely also supported for online upgrades to TW.

Yep, but one should first update to 15.2. That was what I was told by @scarabeusiv.

I would recommend that as well, but it's not required and not documented: https://en.opensuse.org/openSUSE:Tumbleweed_upgrade

@mlschroe Was zstd support backported all the way back to 15.0 or just 15.2?

Just 15.2, it's not present in 15.1.

Ok, so this has to wait until 15.1 is EOL at least.

@marxin
Copy link
Contributor

marxin commented Jul 10, 2020

@mlschroe May I please ping? It's a nice clean up.

@oshanz
Copy link

oshanz commented Mar 26, 2021

I'm interested of this ticket. what is the status? 15.1 is at EOL now

@marxin
Copy link
Contributor

marxin commented Mar 26, 2021

We currently use zstd in openSUSE:Tumbleweed where the suggested patch became part of https://build.opensuse.org/package/show/Base:System/rpm package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Changes/Switch RPMs to zstd compression
4 participants