Fix regression in dynamic pillarenv (bsc#1124277) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dincamihai
force-pushed
the
openSUSE-2018.3.0-bsc#1124277
branch
2 times, most recently
from
166f614
to
2c623be
Compare
dincamihai
force-pushed
the
openSUSE-2018.3.0-bsc#1124277
branch
from
2c623be
to
ef1160d
Compare
dincamihai
changed the title
meaksh
approved these changes
Mar 6, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed patch for https://bugzilla.novell.com/show_bug.cgi?id=1124277
Upstream code is different (probably because of other backportings): https://github.com/saltstack/salt/blob/2018.3/salt/utils/gitfs.py#L2992-L3019
Just using the upstream implementation of that function doesn't work because it needs some changes to code outside the function. Since it is hard to establish what exactly needs to be ported from upstream, I have decided to produce a patch that fixes the problem we have even though it's not exactly as upstream.
I hope to unify with upstream at a later time.