Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt._get_domain: don't raise an exception if there is no VM #224

Closed
wants to merge 1 commit into from
Closed

virt._get_domain: don't raise an exception if there is no VM #224

wants to merge 1 commit into from

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Mar 17, 2020

@cbosdo
virt._get_domain: don't raise an exception if there is no VM
f67ae65 
Raising an exception if there is no VM in _get_domain makes sense if
looking for some VMs, but not when listing all VMs.
@meaksh
Copy link
Member

meaksh commented Mar 17, 2020

I've already pushed this here at 08886b6

Thanks @cbosdo ! 👍

@meaksh meaksh closed this Mar 17, 2020
@cbosdo cbosdo deleted the openSUSE-3000-no_vm_fix branch March 17, 2020 10:34
@cbosdo cbosdo mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cbosdo @meaksh