Set passphrase for salt-ssh keys to empty string #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the cmd is not passed to a shell anymore, the "" are taken literally and not as an empty string. Bugzilla report: https://bugzilla.suse.com/show_bug.cgi?id=1178485
agraul
force-pushed
the
fix-salt-ssh-key-passphrase
branch
from
ed75495
to
b27e676
Compare
meaksh
approved these changes
Nov 5, 2020
meaksh
pushed a commit
that referenced
this pull request
Nov 5, 2020
Since the cmd is not passed to a shell anymore, the "" are taken literally and not as an empty string. Bugzilla report: https://bugzilla.suse.com/show_bug.cgi?id=1178485
meaksh
pushed a commit
that referenced
this pull request
Nov 6, 2020
Since the cmd is not passed to a shell anymore, the "" are taken literally and not as an empty string. Bugzilla report: https://bugzilla.suse.com/show_bug.cgi?id=1178485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix regression in CVE fix
Previous Behavior
ssh key passphrase was
""New Behavior
ssh key passphrase is empty
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.