3004: Ignore non utf8 characters while reading files with core grains module #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
force-pushed
the
ignore-non-utf8-with-core-grains-3004
branch
from
3383b03
to
777fcaa
Compare
|
Let's try again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
UnicodeDecodeErrorexception is possible while reading one of the following files if there is any non utf8 character (for example0x80):/proc/1/environ/proc/1/cmdline/proc/cmdlineIt's safe just to ignore these characters.
Note: No need to backport it. As it makes sense for salt running with Python 3
Previous Behavior
Possible tracebacks on invoking
coregrains module.New Behavior
Normal behavior with ignoring characters causing the tracebacks.
What issues does this PR fix or reference?
Upstream PR: saltstack/salt#62633
Tracks: https://github.com/SUSE/spacewalk/issues/18668
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.