Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrectly used for any* [updated] #74

Merged
merged 1 commit into from Jul 25, 2012

Conversation

LTe
Copy link
Member

@LTe LTe commented Jul 24, 2012

In rails 2.3.x find method hash always should be on second place
Verify method should work only with hash argument
Update check for find method. Proper use HashLiteral with any
Update check for find with dynamic string.
Remove unnecessary any* between SymbolLiteral and SendWithArguments.
This pattern also recognize {:limit => (any), params[:hello] => :value}.
Method send_file should be always executed with name of file to send
Don't use any* for ActiveRecord .find method

Updated version of #73

In rails 2.3.x find method hash always should be on second place

Verify method should work only with hash argument

Update check for find method. Proper use HashLiteral with any

Update check for find with dynamic string.

Remove unnecessary any* between SymbolLiteral and SendWithArguments.

This pattern also recognize {:limit => (any), params[:hello] => :value}.
Now it is fixed

Method send_file should be always executed with name of file to send

Don't use any* for ActiveRecord .find method
dmajda added a commit that referenced this pull request Jul 25, 2012
Fixes incorrectly used for any* [updated]
@dmajda dmajda merged commit 1a83dcb into openSUSE:master Jul 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants