Skip to content

Commit

Permalink
Improve pkg_appdata readability
Browse files Browse the repository at this point in the history
Moving .first to the pkg_appdata assignment makes checking if a first
element exists easier, a simple if pkg_appdata can be used. Assignments
for @name, @appcategories and @homepage are also slightly nicer to read.
  • Loading branch information
agraul committed Dec 4, 2018
1 parent 9db22c8 commit 7605f07
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions app/controllers/package_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ def show
@default_package = @packages.select { |s| s.project == "#{@baseproject}:Update" }.first ||
@packages.select { |s| [@baseproject, "#{@baseproject}:NonFree"].include? s.project }.first

pkg_appdata = @appdata[:apps].select { |app| app[:pkgname].downcase == @pkgname.downcase }
if !pkg_appdata.first.blank?
@name = pkg_appdata.first[:name]
@appcategories = pkg_appdata.first[:categories]
@homepage = pkg_appdata.first[:homepage]
pkg_appdata = @appdata[:apps].select { |app| app[:pkgname].downcase == @pkgname.downcase }.first
if pkg_appdata
@name = pkg_appdata[:name]
@appcategories = pkg_appdata[:categories]
@homepage = pkg_appdata[:homepage]
end

@screenshot = url_for :controller => :package, :action => :screenshot, :package => @pkgname, protocol: request.protocol
Expand Down

0 comments on commit 7605f07

Please sign in to comment.