Merge pull request #16 from openSUSE/review_121218_fixes

[Review] Request from 'digitaltom' @ 'openSUSE/software-o-o/review_121218_fixes'

app/controllers/application_controller.rb

@@ -17,15 +17,13 @@ class MissingParameterError < Exception; end
 
   protected
 
-  rescue_from MissingParameterError do |exception|
+  rescue_from Exception do |exception|
     logger.error "Exception: #{exception.class}: #{exception.message}"
     logger.error exception.backtrace.join("\n")
     @message = exception.message
-    if request.xhr?
-      render :template => "error", :layout => false, :status => 400
-    else
-      render :template => 'error', :layout => "application", :status => 400
-    end
+    layout = request.xhr? ? false : "application"
+    notify_hoptoad(exception)
+    render :template => 'error', :layout => layout, :status => 400
   end
 
   def set_language

app/views/download/appliance.erb

@@ -32,7 +32,7 @@
   end
 %>
 
-  <%= render(:partial => "download.css") %>
+  <%= render(:partial => "download", :formats => [:css]) %>
 
   <% unless @flavors.blank? %>
     <div class="soo_box">

lib/api_connect.rb

@@ -15,7 +15,7 @@ def self.get(path)
       api_user = CONFIG['api_username']
       api_pass = CONFIG['api_password']
       request['x-username'] = api_user
-      # if you know the cookie, you can buypass login - useful in production ;)
+      # if you know the cookie, you can bypass login - useful in production ;)
       request['X-opensuse_data'] = CONFIG['opensuse_cookie'] if CONFIG['opensuse_cookie']
       request.basic_auth  api_user, api_pass unless (api_user.blank? || api_pass.blank?)
       http.read_timeout = 15
@@ -26,8 +26,7 @@ def self.get(path)
         raise "Response was: #{response} #{response.body}"
       end
     rescue Exception => e
-      logger.error "Error connecting to #{uri_str}: #{e.to_s}"
-      return nil
+      raise "Error connecting to #{uri_str}: #{e.to_s}"
     end
   end