Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download page has a space between the repo URL and "Release.key" for Debian repos #650

Closed
dwfreed opened this issue Aug 22, 2019 · 3 comments · Fixed by #655
Closed

Download page has a space between the repo URL and "Release.key" for Debian repos #650

dwfreed opened this issue Aug 22, 2019 · 3 comments · Fixed by #655
Labels
Bug 💀

Comments

@dwfreed
Copy link

dwfreed commented Aug 22, 2019 •
edited
Loading

software-o-o/app/views/download/package.erb

Line 83 in 3938166

"echo 'deb #{v[:repo].gsub(/(\w):(\w)/, '\1:/\2').gsub(/^https/, 'http')} /' > /etc/apt/sources.list.d/#{@project}.list\nwget -nv #{v[:repo]} Release.key -O Release.key\napt-key add - < Release.key\napt-get update\napt-get install #{@package}"

This contains a space after the repo URL and before "Release.key" making the wget command invalid. Only applies to Debian repos.

(Edit note: accidentally hit enter when in the title box, so GitHub submitted the issue... Thanks GitHub)
@dwfreed dwfreed changed the title Download page has a space between the repo URL and Download page has a space between the repo URL and "Release.key" for Debian repos Aug 22, 2019
@agraul
Copy link
Member

agraul commented Aug 23, 2019

Hi @dwfreed ,thanks for reporting the issue 😃 ! As you already found the location in the code and how to fix it, do you mind sending a PR with the fix ?

@agraul agraul mentioned this issue Sep 1, 2019
Closed
agraul added a commit to agraul/software-o-o that referenced this issue Sep 1, 2019
@agraul
Fix Debian Release.key URL
0f01739 
A space found its way into the URL between the dynamic part and
"Release.key" which breaks the generated URL for Debian users.

Fixes openSUSE#650.
@agraul agraul mentioned this issue Sep 1, 2019
Merged
@Ana06 Ana06 closed this as completed in #655 Sep 3, 2019
@tennox
Copy link

tennox commented Sep 17, 2019

It's either not fixed or not deployed yet:
https://software.opensuse.org/download.html?project=shells%3Afish%3Arelease%3A3&package=fish

@agraul
Copy link
Member

agraul commented Sep 18, 2019

@tennox it should be fixed now, I've just deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 💀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Debian Release.key URL agraul/software-o-o
3 participants
@dwfreed @tennox @agraul