Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method `[]' for nil:NilClass upon searching for appimages on software.o.o #885

Closed
evrardjp opened this issue Oct 27, 2020 · 4 comments · Fixed by #889
Closed

undefined method `[]' for nil:NilClass upon searching for appimages on software.o.o #885

evrardjp opened this issue Oct 27, 2020 · 4 comments · Fixed by #889

Comments

@evrardjp
Copy link

all in the title. :)
@hellcp
Copy link
Member

hellcp commented Oct 27, 2020

Fairly sure it's still the openSUSE/open-build-service#4514 bug, software-o-o doesn't see any binaries from Appimage existing at all, so it errors out

@evrardjp
Copy link
Author

I am not deeply aware of how that works internally sadly, I am inclined to say that the exception could be made more explicit for the end user, but that's also okay if it's solved somewhere else.

Thanks for the fast answer and being on top of this, @hellcp !

@agraul
Copy link
Member

agraul commented Oct 27, 2020

@evrardjp there shouldn't be such an error exposed when we don't find appimages, you're right in reporting that. I'll remove that exception and show the regular 'can't find anything' here until OBS exposes AppImages or we move to a different way of searching (that does not use OBS' API)

agraul added a commit to agraul/software-o-o that referenced this issue Oct 27, 2020
@agraul
Prevent exceptions when accessing @appdata
5445965 
For many distributions we don't load @appdata. @appdata is still
accessed, expecting that it always exists and contains :apps and
:categories. With this change, those accesses don't throw exceptions.

Fixes openSUSE#885.
agraul added a commit to agraul/software-o-o that referenced this issue Oct 27, 2020
@agraul
Prevent exceptions when accessing @appdata
f70cc19 
For many distributions we don't load @appdata. @appdata is still
accessed, expecting that it always exists and contains :apps and
:categories. With this change, those accesses don't throw exceptions.

Fixes openSUSE#885.
@agraul agraul mentioned this issue Oct 27, 2020
Merged
1 task
agraul added a commit to agraul/software-o-o that referenced this issue Oct 27, 2020
@agraul
Prevent exceptions when accessing @appdata
93dfafc 
For many distributions we don't load @appdata. @appdata is still
accessed, expecting that it always exists and contains :apps and
:categories. With this change, those accesses don't throw exceptions.

Fixes openSUSE#885.
@evrardjp
Copy link
Author

Thanks!

agraul added a commit to agraul/software-o-o that referenced this issue Oct 30, 2020
@agraul
Prevent exceptions when accessing @appdata
3a4b468 
For many distributions we don't load @appdata. @appdata is still
accessed, expecting that it always exists and contains :apps and
:categories. With this change, those accesses don't throw exceptions.

Fixes openSUSE#885.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent exceptions when accessing @appdata agraul/software-o-o
3 participants
@evrardjp @agraul @hellcp