Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-performance: 1.11.5 → 1.13.3 (minor) #1151

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 24, 2022

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-performance (1.11.5 → 1.13.3) · Repo · Changelog

Release Notes

1.13.3

Bug fixes

  • #285: Fix an error for Performance/MapCompact when using map(&:do_something).compact.first and there is a line break after map.compact and receiver. (@ydah)

1.13.2

Bug fixes

  • #281: Fix an error for Performance/BlockGivenWithExplicitBlock when using Ruby 3.1's anonymous block forwarding. (@koic)

1.13.1

Bug fixes

  • #278: Fix a false positive for Performance/StringIdentifierArgument when using attr. (@koic)

1.13.0

New features

  • #276: Add new Performance/StringIdentifierArgument cop. (@koic)
  • #204: Add Performance/Sum option to ignore potential false positives. (@leoarnold)
  • #269: Add #to_d support to BigDecimalWithNumericArgument. (@leoarnold)

Bug fixes

  • #277: Fix an incorrect autocorrect for Performance/MapCompact when using map.compact.first and there is a line break after map.compact and receiver. (@koic)
  • #273: Fix an incorrect autocorrect for Performance/RedundantStringChars when using str.chars[0]. (@koic)

Changes

  • #270: Mark Performance/Sum auto-correction as unsafe and extend documentation. (@leoarnold)
  • #274: Unmark AutoCorrect: false from Performance/CaseWhenSplat. (@koic)
  • #275: Unmark AutoCorrect: false from Performance/TimesMap. (@koic)

1.12.0

New features

  • #267: Add new Performance/ConcurrentMonotonicTime cop. (@koic)

Bug fixes

  • #261: Fix a false negative for Performance/RedundantBlockCall when using block.call in a class method'. (@koic)
  • #264: Fix error in Performance/Sum when method has no brackets. (@mvz)

Changes

  • #263: Unmark AutoCorrect: false from Performance/StringInclude. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.22.0 → 1.26.1) · Repo · Changelog

Release Notes

1.26.1

Bug fixes

  • #10375: Fix error for auto-correction of unless/else nested inside each other. (@jonas054)
  • #10457: Make Style/SelectByRegexp aware of ENV const. (@koic)
  • #10462: Fix an incorrect autocorrect for Lint/SymbolConversion when using a quoted symbol key with hash rocket. (@koic)
  • #10456: Fix a false positive for Layout/MultilineMethodCallIndentation when using EnforcedStyle: indented with indented assignment method. (@koic)
  • #10459: Fix a false positive for Layout/LineLength when long URIs in yardoc comments to have titles. (@ydah)
  • #10447: Fix an error for Style/SoleNestedConditional raises exception when inspecting if ... end if .... (@ydah)

1.26.0

New features

  • #10419: Add new Style/NestedFileDirname cop. (@koic)
  • #10433: Support TargetRubyVersion 3.2 (experimental). (@koic)

Bug fixes

  • #10406: Fix a false positive for Lint/InheritException when inheriting a standard lib exception class that is not a subclass of StandardError. (@koic)
  • #10421: Make Style/DefWithParentheses aware of endless method definition. (@koic)
  • #10401: Fix a false positive for Style/HashSyntax when local variable hash key and hash value are the same. (@koic)
  • #10424: Fix a false positive for Security/YamlLoad when using Ruby 3.1+ (Psych 4). (@koic)
  • #10446: Lint/RedundantDirGlobSort unset SafeAutoCorrect. (@friendlyantz)
  • #10403: Fix an error for Style/StringConcatenation when string concatenation with multiline heredoc text. (@koic)
  • #10432: Fix an error when using regexp with non-encoding option. (@koic)
  • #10415: Fix an error for Lint/UselessTimes when using 1.times with method chain. (@koic)

Changes

  • #10408: Mark Lint/InheritException as unsafe auto-correction. (@koic)
  • #10407: Change EnforcedStyle from runtime_error to standard_error for Lint/InheritException. (@koic)
  • #10414: Update auto-gen-config's auto-correction comments to be more clear. (@maxjacobson)
  • #10427: Mark Style/For as unsafe auto-correction. (@issyl0)
  • #10410: Improve help string for --fail-level CLI option. (@tejasbubane)

1.25.1

Bug fixes

  • #10359: Fix a false positive and negative for Style/HashSyntax when using hash value omission. (@koic)
  • #10387: Fix an error for Style/RedundantBegin when assigning nested begin blocks. (@koic)
  • #10366: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and using hash value omission with modifier from. (@koic)
  • #10376: Fix an error for Layout/RescueEnsureAlignment when using .() call with block. (@koic)
  • #10364: Fix an infinite loop error for Layout/HashAlignment when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. (@koic)
  • #10371: Fix a false negative for Style/HashSyntax when Hash[foo: foo] or {foo: foo} is followed by a next expression. (@koic)
  • #10394: Fix an error for Style/SwapValues when assigning receiver object at def. (@koic)
  • #10379: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when rescue and end are on the same line. (@koic)

1.25.0

New features

  • #10351: Support EnforcedShorthandSyntax: either option for Style/HashSyntax. (@koic)
  • #10339: Support auto-correction for EnforcedStyle: explicit of Naming/BlockForwarding. (@koic)

Bug fixes

  • #10344: Fix a false positive for Style/CollectionCompact when without receiver for bad methods. (@koic)
  • #10353: Use :ambiguous_regexp to detect ambiguous Regexp in Ruby 3. (@danieldiekmeier, @joergschiller)
  • #10336: Fix a false positive for Style/TernaryParentheses when using in keyword pattern matching as a ternary condition. (@koic)
  • #10317: Fix a false positive for Style/MethodCallWithArgsParentheses when using hash value omission. (@koic)
  • #8032: Improve ArgumentAlignment detection and correction for keyword arguments. (@mvz)
  • #10331: Fix cop generator for nested departments. (@fatkodima)
  • #10357: Fix a false positive for Style/HashSyntax when omitting the value. (@berkos)
  • #10335: Fix a false positive for Naming/BlockForwarding when using multiple proc arguments. (@koic)
  • #10350: Fix a false negative for Lint/IncompatibleIoSelectWithFiberScheduler when using IO.select with the first argument only. (@koic)
  • #10358: Fix Style/Sample crash on beginless and endless range shuffle indexes. (@gsamokovarov)
  • #10354: Fix Gemspec/RequiredRubyVersion version matcher when Gem::Requirement.new is used and initialised with multiple requirements. (@nickpellant)

Changes

1.24.1

Bug fixes

  • #10313: Fix autocorrect Style/MapToHash with multiline code. (@tejasbubane)
  • #10251: Fix an incorrect autocorrect for Gemspec/RequireMFA when .gemspec file contains metadata keys assignments. (@fatkodima)
  • #10329: Fix a false positive for Lint/ParenthesesAsGroupedExpression and an incorrect autocorrect for the cop with Style/TernaryParentheses when using ternary expression as a first argument. (@koic)
  • #10317: Fix a false positive for Style/MethodCallWithArgsParentheses when using hash value omission. (@koic)
  • #10333: Fix an incorrect autocorrect for Naming/BlockForwarding using explicit block forwarding without method definition parentheses. (@koic)
  • #10321: Make Style/MethodDefParentheses aware of Ruby 3.1's anonymous block forwarding. (@koic)
  • #10320: Fix an incorrect autocorrect for Style/FileWrite when using heredoc argument. (@koic)
  • #10319: Require rubocop-ast 1.15.1 to fix a false positive for Style/CombinableLoop when the same method with different arguments and safe navigation. (@koic)

1.24.0

New features

  • #10279: Support Ruby 3.1's anonymous block forwarding syntax. (@koic)
  • #10295: Support Ruby 3.1's hash value omission syntax for Layout/HashAlignment. (@koic)
  • #10303: Add AllowedNumbers option to Style/NumericLiterals. (@koic)
  • #10290: Add new Naming/BlockForwarding cop. (@koic)
  • #10289: Add EnforcedShorthandSyntax option to Style/HashSyntax cop to support Ruby 3.1's hash value omission syntax by default. (@koic)
  • #10257: Add new Style/MapToHash cop. (@dvandersluis)
  • #10261: Add new Style/FileRead cop. (@leoarnold)
  • #10291: Support Ruby 3.1's hash value omission syntax for Layout/SpaceAfterColon. (@koic)
  • #10260: Add new Style/FileWrite cop. (@leoarnold)
  • #10307: Support Ruby 2.7's numbered parameter for Metrics/BlockLength, Metrics/ClassLength, Metrics/MethodLength, and Metrics/ModuleLength cops. (@koic)
  • #7671: Add cli option --show-docs-url to print out documentation url for given cops. (@HeroProtagonist)
  • #10308: Make Style/CollectionCompact aware of block pass argument. (@koic)

Bug fixes

  • #10285: Fix an incorrect autocorrect for Style/SoleNestedConditional when using nested if within if foo = bar. (@koic)
  • #10309: Fix a false positive for Bundler/DuplicatedGem when a gem conditionally duplicated within multi-statement bodies. (@fatkodima)
  • #10300: Fix an incorrect autocorrect for Layout/DotPosition and Style/RedundantSelf when auto-correction conflicts. (@koic)
  • #10284: Fix an incorrect autocorrect for Style/RedundantRegexpCharacterClass when regexp containing an unescaped #. (@koic)
  • #10265: Fix Style/IfInsideElse to be able to handle if-then nested inside an else without clobbering. (@dvandersluis)
  • #10297: Fix a false positive for Lint/DeprecatedOpenSSLConstant when building digest using an algorithm string and nested digest constants. (@koic)
  • #10282: Fix an incorrect autocorrect for Style/EmptyCaseCondition when using when ... then in case in a method call. (@koic)
  • #10273: Fix a false positive for InternalAffairs/UndefinedConfig to suppress a false wrong namespace warning. (@koic)
  • #10305: Fix an incorrect autocorrect for Style/HashConversion when using Hash[a || b]. (@koic)
  • #10264: Fix the following incorrect auto-correct for Style/MethodCallWithArgsParentheses with Layout/SpaceBeforeFirstArg. (@koic)
  • #10276: Fix an incorrect autocorrect for Style/RedundantInterpolation when using a method call without parentheses in string interpolation. (@koic)

Changes

  • #10253: Deprecate RuboCop::Cop::EnforceSuperclass module. (@koic)
  • #10248: Make Lint/DeprecatedClassMethods aware of ENV.freeze. (@koic)
  • #10269: Mark Lint/IncompatibleIoSelectWithFiberScheduler as unsafe auto-correction. (@koic)
  • #8586: Add configuration parameter AllowForAlignment in Layout/CommentIndentation. (@jonas054)

1.23.0

New features

Bug fixes

  • #10203: Fix Style/FormatStringToken to respect IgnoredMethods with nested structures. (@tejasbubane)
  • #10242: Fix last_column value for JSONFormatter. (@koic)
  • #10229: Fix a false positive for Style/StringLiterals when EnforcedStyle: double_quotes and using single quoted string with backslash. (@koic)
  • #10174: Fix inherit_from_remote should follow remote includes path starting with ./. (@hirasawayuki)
  • #10234: Fix an error for Style/Documentation when using a cbase class. (@koic)
  • #10227: Fix a false positive for Style/ParenthesesAroundCondition when parentheses in multiple expressions separated by semicolon. (@koic)
  • #10230: Fix a false positive for Lint/AmbiguousRange when a range is composed of all literals except basic literals. (@koic)

Changes

  • #10221: Update Naming::FileName to recognize Structs as classes that satisfy the ExpectMatchingDefinition requirement. (@dvandersluis)
  • #10220: Update Naming/FileName to make CheckDefinitionPathHierarchy roots configurable. (@grosser)
  • #10199: Change AllowAdjacentOneLineDefs config parameter of Layout/EmptyLineBetweenDefs to true by default . (@koic)
  • #10236: Make Lint/NumberConversion aware of to_r. (@koic)

1.22.3

Bug fixes

  • #10166: Fix a false positive for Style/StringLiterals when using some meta characters (e.g. '\s', '\z') with EnforcedStyle: double_quotes. (@koic)
  • #10216: Fix an incorrect autocorrect for Style/SelectByRegexp when using lvar =~ blockvar in a block. (@koic)
  • #10207: Fix false positive in Layout/DotPosition when the selector is on the same line as the closing bracket of the receiver. (@mvz)

Changes

  • #10209: Make Lint/DeprecatedConstants aware of Net::HTTPServerException. (@koic)

1.22.2

Bug fixes

  • #10165: Fix Layout/DotPosition false positives when the selector and receiver are on the same line. (@dvandersluis)
  • #10171: Fix Style/HashTransformKeys and Style/HashTransformValues incorrect auto-correction when inside block body. (@franzliedke)
  • #10180: Fix an error for Style/SelectByRegexp when using match? without a receiver. (@koic)
  • #10193: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when begin and rescue are on the same line. (@koic)
  • #10185: Fix a false positive for Lint/AmbiguousRange when using self in a range literal. (@koic)
  • #10200: Fix an error when inspecting a directory named *. (@koic)
  • #10149: Fix Bundler/GemComment where it would not detect an offense in some cases when OnlyFor is set to restrictive_version_specifiers. (@Drowze)

Changes

  • #10157: Updated Gemspec/RequiredRubyVersion handle being set to blank values. (@dvandersluis)
  • #10176: Unmark AutoCorrect: false from Security/JSONLoad. (@koic)
  • #10186: Explicit block arg is not counted for Metrics/ParameterLists. (@koic)

1.22.1

Bug fixes

  • #10143: Fix an error for Lint/RequireRelativeSelfPath when using a variable as an argument of require_relative. (@koic)
  • #10140: Fix false positive for Layout/DotPosition when a heredoc receives a method on the same line as the start sigil in trailing style. (@dvandersluis)
  • #10148: Fix Style/QuotedSymbols handling escaped characters incorrectly. (@dvandersluis)
  • #10145: Update Style/SelectByRegexp to ignore cases where the receiver appears to be a hash. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.21.0 → 1.22.0) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.0.2.0 → 3.1.1.0) · Repo · Changelog

Release Notes

3.1.1.0 (from changelog)

API modifications:

  • Bump 3.1 branch to 3.1.1 (Koichi ITO)

Features implemented:

  • ruby32.y: Reuse operation rule for operation2 (Koichi ITO)
  • ruby32.y: Reuse p_kwnorest rule for f_no_kwarg (Koichi ITO)
  • ruby-parse: add ability to read fragment from stdin (#844) (Jeremy Stanley)
  • ruby32.y: reduce p_args with p_rest (#843) (Vladimir Dementyev)
  • ruby32.y: branch parser (#841) (Ilya Bylich)

3.1.0.0 (from changelog)

API modifications:

  • parser/current: update for 3.1.0 release. (#840) (Ilya Bylich)

Features implemented:

  • ruby31.y: accept forward arg without parentheses. (#839) (Ilya Bylich)

3.0.3.2 (from changelog)

Bugs fixed:

  • dedenter.rb: fix an encoding/squiggly heredoc regression (#836) (hmdne)

3.0.3.1 (from changelog)

Features implemented:

  • ruby31.y: parse anonymous block argument. (#833) (Ilya Bylich)
  • ruby31.y: parse forward argument without parentheses (#832) (Ilya Bylich)

3.0.3.0 (from changelog)

API modifications:

  • Bump maintenance branches to 3.0.3, 2.7.5, and 2.6.9 (#829) (Koichi ITO)

Features implemented:

  • lexer.rl: parse meta-control-hex chars in regexes starting from 3.1 (#828) (Ilya Bylich)
  • builder.rb: warn on duplicate hash key literals. (#827) (Ilya Bylich)
  • ruby31.y: Allow value omission in Hash literals (#818) (Svyatoslav Kryukov)
  • ruby31.y: Allow omission of parentheses in one line pattern matching (#816) (Koichi ITO)
  • ruby31.y: Add pattern matching pin support for instance/class/global variables (#813) (Koichi ITO)

Bugs fixed:

  • ruby31.y: handle local variables as hash labels with omitted values (#820) (Ilya Bylich)
  • lexer.rl: Fix handling of beginless ranges at start of line (#822) (Matijs van Zuijlen)
  • dedenter.rb: Fix squiggly heredoc line continuation handling (#819) (Matijs van Zuijlen)
  • lexer.rl: fix incompatible delimiters on percent literal (#808) (Masataka Pocke Kuwabara)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rainbow (indirect, 3.0.0 → 3.1.1) · Repo · Changelog

Release Notes

3.1.1 (from changelog)

  • fix: Ensure files directive in gemspec adds all files

3.1.0 (from changelog)

  • Bad release: superseded by 3.1.1.
  • added cross_out aka strike
  • hexadecimal color names supported better, see #83
  • gemspec: list files using a Ruby expression, avoiding git

(2020-08-26 was the planned release date, but the real release date is reflected in the heading.)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.12.0 → 1.16.0) · Repo · Changelog

Release Notes

1.16.0 (from changelog)

New features

  • #223: Support Parser::Ruby32 for Ruby 3.2 parser (experimental). (@koic)

1.15.2 (from changelog)

Bug fixes

1.15.1 (from changelog)

Bug fixes

  • #10220: Make AST::Node#receiver aware of csend block method calls. (@koic)

1.15.0 (from changelog)

New features

  • #10219: Add value_omission method to AST::PairNode for Ruby 3.1's hash value omission. (@koic)

1.14.0 (from changelog)

New features

  • #218: Support Ruby 3.1's anonymous block forwarding syntax. (@koic)

1.13.0 (from changelog)

New features

  • #213: Make Node#numeric_type? aware of rational and complex literals. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 24, 2022
@hennevogel hennevogel force-pushed the depfu/update/rubocop-performance-1.13.3 branch 2 times, most recently from 3a22368 to fb0260e Compare March 24, 2022 16:29
@hellcp hellcp force-pushed the depfu/update/rubocop-performance-1.13.3 branch from fb0260e to 1fefb0e Compare March 29, 2022 14:36
@hellcp hellcp merged commit 0f600ba into master Mar 29, 2022
@depfu depfu bot deleted the depfu/update/rubocop-performance-1.13.3 branch March 29, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant