Fix appdata parsing #181
Merged
Fix appdata parsing #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
guoyunhe
reviewed
Jul 27, 2017
There was a problem hiding this comment.
hmm, I am not really a Ruby expert. I remember I have seen this problem one year ago. https://github.com/openSUSE/software-o-o/pull/121/files#diff-2304bd464c39d51ebb8120d3be4e9039
However, this behavior might changed after Ruby updates.
coolo
reviewed
Jul 27, 2017
app/models/appdata.rb
Outdated
| @@ -39,10 +45,12 @@ def self.get_distribution dist = "factory", flavour = "oss" | |||
| else | |||
| "http://download.opensuse.org/distribution/#{dist}/repo/#{flavour}/suse/setup/descr/appdata.xml.gz" | |||
| end | |||
| filename = File.join(Rails.root.join('tmp'), "appdata-" + dist + ".xml") | |||
| logger.debug("fetching appdata for #{dist}/#{flavour}") | |||
| filename = File.join(Rails.root.join('tmp'), "appdata-#{dist}-#{flavour}.xml.gz") | |||
There was a problem hiding this comment.
you store uncompressed data into it, so you better stay with .xml
In contrast to the previous comment open-uri does not decompress the stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.