Merge pull request #401 from mtomaschewski/dhcp-no-release

dhcp4: do not release and remove lease without request (bnc#866994)
openSUSE · Sep 3, 2014 · 2454fd7 · 2454fd7
2 parents 60fef7d + d235e1e
commit 2454fd7
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/dhcp4/fsm.c b/dhcp4/fsm.c
@@ -53,7 +53,9 @@ ni_dhcp4_defer_timeout(void *user_data, const ni_timer_t *timer)
 		ni_warn("%s: bad timer handle", __func__);
 		return;
 	}
-	ni_note("%s: DHCLIENT_WAIT_AT_BOOT=%u reached (state %s)", dev->ifname, dev->config->defer_timeout, ni_dhcp4_fsm_state_name(dev->fsm.state));
+	ni_note("%s: defer timeout %u reached (state %s)",
+		dev->ifname, dev->config->defer_timeout,
+		ni_dhcp4_fsm_state_name(dev->fsm.state));
 	ni_dhcp4_send_event(NI_DHCP4_EVENT_DEFERRED, dev, NULL);
 }
 
@@ -473,9 +475,12 @@ ni_dhcp4_fsm_release(ni_dhcp4_device_t *dev)
 	if (dev->config->release_lease) {
 		ni_debug_dhcp("%s: releasing lease", dev->ifname);
 		ni_dhcp4_device_send_message(dev, DHCP4_RELEASE, dev->lease);
+		ni_dhcp4_fsm_commit_lease(dev, NULL);
+	} else {
+		ni_dhcp4_device_drop_lease(dev);
+		ni_dhcp4_send_event(NI_DHCP4_EVENT_RELEASED, dev, NULL);
+		ni_dhcp4_fsm_restart(dev);
 	}
-
-	ni_dhcp4_fsm_commit_lease(dev, NULL);
 }
 
 /*