Skip to content

Commit

Permalink
iflist: free masterdev name if it references invalid device
Browse files Browse the repository at this point in the history
We were freeing masterdev.name on a successful call to
ni_netdev_ref_bind_ifname(). This prevented ifstatus from reporting master
devices correctly for bridges/bonds.
  • Loading branch information
kmroz committed Sep 11, 2014
1 parent eab5dba commit 650a3cb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/iflist.c
Expand Up @@ -929,7 +929,7 @@ __ni_process_ifinfomsg_linkinfo(ni_linkinfo_t *link, const char *ifname,

if (tb[IFLA_MASTER]) {
link->masterdev.index = nla_get_u32(tb[IFLA_MASTER]);
if (ni_netdev_ref_bind_ifname(&link->masterdev, nc)) {
if (!ni_netdev_ref_bind_ifname(&link->masterdev, nc)) {
/* Drop old ifname, we will try it again later */
ni_string_free(&link->masterdev.name);
}
Expand Down

0 comments on commit 650a3cb

Please sign in to comment.