New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
team: add new options like link_watch_policy (jsc#PED-7183) #1000
team: add new options like link_watch_policy (jsc#PED-7183) #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't tested it yet, but there is an issue with adding lw->arp.missed_max
as vlanid
to the dict and some CI warnings about long line, ...
31eb6bc
to
02340da
Compare
use the following command to generate the manpage ``` pandoc man/src/ifcfg-team.5.md -s -t man > man/ifcfg-team.5.in ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ni_dbus_dict_add_uint32(result, "interval", m->count);
typos...
7b59613
to
ef79d6d
Compare
After verbal discussion, we decided to postpone this additional check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now we have it.
This implements the following new teamd options:
TEAM_LINK_WATCH_POLICY
=>link_watch_policy
TEAM_LW_ARP_PING_VLANID
=>link_watch.vlanid
TEAM_NOTIFY_PEERS_COUNT
=>notify_peers.count
TEAM_NOTIFY_PEERS_INTERVAL
=>notify_peers.interval
TEAM_MCAST_REJOIN_COUNT
=>mcast_rejoin.count
TEAM_MCAST_REJOIN_INTERVAL
=>mcast_rejoin.interval
TEAM_DEBUG_LEVEL
=>debug_level