Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team: add new options like link_watch_policy (jsc#PED-7183) #1000

Merged
merged 10 commits into from Feb 23, 2024

Conversation

cfconrad
Copy link
Collaborator

This implements the following new teamd options:

  • TEAM_LINK_WATCH_POLICY => link_watch_policy
  • TEAM_LW_ARP_PING_VLANID => link_watch.vlanid
  • TEAM_NOTIFY_PEERS_COUNT => notify_peers.count
  • TEAM_NOTIFY_PEERS_INTERVAL => notify_peers.interval
  • TEAM_MCAST_REJOIN_COUNT => mcast_rejoin.count
  • TEAM_MCAST_REJOIN_INTERVAL => mcast_rejoin.interval
  • TEAM_DEBUG_LEVEL => debug_level

@mtomaschewski mtomaschewski changed the title Add new teamd options like link_watch_policy Add new teamd options like link_watch_policy (jsc#PED-7183) Feb 21, 2024
Copy link
Member

@mtomaschewski mtomaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't tested it yet, but there is an issue with adding lw->arp.missed_max
as vlanid to the dict and some CI warnings about long line, ...

include/wicked/team.h Outdated Show resolved Hide resolved
client/compat.c Show resolved Hide resolved
client/compat.c Show resolved Hide resolved
src/dbus-objects/team.c Outdated Show resolved Hide resolved
@cfconrad cfconrad force-pushed the fix_PED2208_new_teamd_options branch 2 times, most recently from 31eb6bc to 02340da Compare February 22, 2024 16:10
@mtomaschewski mtomaschewski changed the title Add new teamd options like link_watch_policy (jsc#PED-7183) team: add new options like link_watch_policy (jsc#PED-7183) Feb 22, 2024
Copy link
Member

@mtomaschewski mtomaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@mtomaschewski mtomaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ni_dbus_dict_add_uint32(result, "interval", m->count);

typos...

src/dbus-objects/team.c Outdated Show resolved Hide resolved
src/dbus-objects/team.c Outdated Show resolved Hide resolved
@cfconrad cfconrad force-pushed the fix_PED2208_new_teamd_options branch 2 times, most recently from 7b59613 to ef79d6d Compare February 23, 2024 09:46
@cfconrad
Copy link
Collaborator Author

After verbal discussion, we decided to postpone this additional check for TEAM_LW_ARP_PING_INTERVAL and TEAM_LW_NSNA_PING_INTERVAL (7b59613) as it is not needed with latest libteam 1.32

Copy link
Member

@mtomaschewski mtomaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now we have it.

@mtomaschewski mtomaschewski merged commit d324d32 into openSUSE:master Feb 23, 2024
@cfconrad cfconrad deleted the fix_PED2208_new_teamd_options branch March 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants