hide secrets in debug log (bsc#1221194) #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfconrad
force-pushed
the
hide_secrets_from_logs
branch
2 times, most recently
from
22901e9
to
d1047fc
Compare
There was a problem hiding this comment.
src/appconfig.c is about the /etc/wicked/*.xml appconfig files -- extension definition config in this case and not about interface configs/polices.
|
I would simply use |
Replaces cdata in a copy of a config node and it's children that contain passwords before logging it.
cfconrad
force-pushed
the
hide_secrets_from_logs
branch
from
d1047fc
to
909ee2f
Compare
mtomaschewski
requested changes
Mar 19, 2024
There was a problem hiding this comment.
See previous comment. Commit d1047fc is not needed and I'd not add it.
The xml does not contain any passwords (which would be valid for all users) and will never do. It's useless to clone the appconfig extension definition for nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces cdata in a copy of a config node and it's children that contain passwords before logging it.
Please merge #1005 first.