Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp4: do not set/query mtu if set in the config (bsc#904323) #493

Merged
2 commits merged into from
Jan 29, 2015

Conversation

mtomaschewski
Copy link
Member

No description provided.

@okirch
Copy link
Contributor

okirch commented Jan 28, 2015

Just a quick comment, the part of the patch that handles print_doflags maps the "mtu" string to DO_NTP...

Olaf

Am 28.01.2015 um 18:45 schrieb Marius Tomaschewski notifications@github.com:

You can view, comment on, or merge this pull request online at:

#493

Commit Summary

dhcp4: do not set/query mtu if set in the config (bsc#904323)
File Changes

M client/suse/compat-suse.c (1)
M dhcp4/device.c (2)
M dhcp4/dhcp.h (1)
M dhcp4/protocol.c (4)
M include/wicked/addrconf.h (1)
M src/ifconfig.c (3)
M src/names.c (1)
Patch Links:

https://github.com/openSUSE/wicked/pull/493.patch
https://github.com/openSUSE/wicked/pull/493.diff

Reply to this email directly or view it on GitHub.

MTU of 576 disables path mtu discovery and breaks internet
connections to several ISPs, see bnc#791280 for details.
@mtomaschewski
Copy link
Member Author

Thanks!

-       { "mtu",                DHCP4_DO_NTP            },
+       { "mtu",                DHCP4_DO_MTU            },

@ghost
Copy link

ghost commented Jan 29, 2015

Works on my end also!

ghost pushed a commit that referenced this pull request Jan 29, 2015
dhcp4: do not set/query mtu if set in the config (bsc#904323)
@ghost ghost merged commit 340f1f8 into openSUSE:master Jan 29, 2015
@mtomaschewski mtomaschewski deleted the dhcp4-mtu branch February 3, 2015 13:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants