ifconfig: set MTU even if device is up (bsc#1059292) #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtomaschewski
changed the title
wicked should not supplement what drivers in kernel are capable. That means, that if device is up, and is not capable set MTU on-fly, kernel returns error. This is driver problem, not wicked and should just print an error and continue. Signed-off-by: Nikola Pajkovsky <npajkovsky@suse.cz>
mtomaschewski
force-pushed
the
device-up-mtu
branch
from
33605d7
to
01d4838
Compare
mtomaschewski
added a commit
to mtomaschewski/wicked
that referenced
this pull request
Dec 15, 2017
ifconfig: set MTU even if device is up (bsc#1059292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wicked should not supplement what drivers in kernel are capable. That
means, that if device is up, and is not capable set MTU on-fly, kernel
returns error. This is driver problem, not wicked and should just
print an error and continue.
Signed-off-by: Nikola Pajkovsky npajkovsky@suse.cz