New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wireless: reconnect on unexpected wpa_supplicant restart (bsc#1183495) #892
Merged
mtomaschewski
merged 9 commits into
openSUSE:master
from
cfconrad:wip-wireless_fix_wpa_supplicant_restart_handling
Dec 1, 2021
Merged
wireless: reconnect on unexpected wpa_supplicant restart (bsc#1183495) #892
mtomaschewski
merged 9 commits into
openSUSE:master
from
cfconrad:wip-wireless_fix_wpa_supplicant_restart_handling
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be ni_wireless_t object without successful applied configuration. Such objects are identified by `wlan->config == NULL`. For this reason, the ni_wireless_config_t object is now referenced by a pointer inside of ni_wireless_t.
Remember, if we have enabled all network(s) in wpa_supplicant. This is used to to re-trigger it, while recover after wpa_supplicant restarts.
If wpa_supplicant restarts unexpected, we need to configure wpa_supplicant again, as the previous configuration is lost.
cfconrad
force-pushed
the
wip-wireless_fix_wpa_supplicant_restart_handling
branch
from
November 26, 2021 10:09
4aadf69
to
ffd7991
Compare
mtomaschewski
changed the title
Fix wireless connection disruption on unexpected wpa_supplicant restart (bsc#1183495)
wireless: reconnect on unexpected wpa_supplicant restart (bsc#1183495)
Dec 1, 2021
mtomaschewski
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and worked fine on my notebook, thanks!
mtomaschewski
added a commit
that referenced
this pull request
Dec 9, 2021
cleanup: warnings, time calculations and dhcp fixes (bsc#1188019) - Cleanup timer/timeout and lifetime types and calculations with very high or infinite lease time, which caused high cpu on RaspberryPi 2 (bsc#1188019) - dhcp6: fix incorrect retransmission time randomization (re-)calculations USGv6: DHCPv6_7_1_05c, DHCPv6_7_1_05c, DHCPv6_7_1_05c - fix warnings from more recent compilers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wpa_supplicant get restarted (e.g. in case of an update) the previous configuration is lost.
As we configure wpa_supplicant via DBus, there is no persistent state by default, thus we need to send the
configuration again, once wpa_supplicant is back on the DBus.
Bug: https://bugzilla.suse.com/show_bug.cgi?id=1183495