nanny: fix use-after-free in debug mode (bsc#1206447) #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a use-after-free by getting a local mpolicy->fsm_policy reference in unregister_managed_policy to safely access the fsm policy name for a debug message logged after unregistering the mpolicy object, which is freeing the mpolicy (if it's the last reference). A policy deletion is performed by wicked ifdown or ifreload and the execution is limited to root (uid 0) callers, so it does not bring additional privilege possibilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a use-after-free by getting a local mpolicy->fsm_policy reference in unregister_managed_policy to safely access the fsm policy name for a debug message logged after unregistering the mpolicy object, which is freeing the mpolicy (if it's the last reference).
A policy deletion is performed by wicked ifdown or ifreload and the execution is limited to root (uid 0) callers, so it does not bring additional privilege possibilities.